feat: partner node index (index.partner_node.json) + scan/build pipeline - #1111
Draft
comfyui-wiki wants to merge 3 commits into
Draft
comfyui-wiki wants to merge 3 commits into
comfyui-wiki wants to merge 3 commits into
Conversation
Add a node-centric index of ComfyUI partner API nodes: - templates/index.partner_node.json: 227 nodes with model options, capabilities, recommendation flags, release dates and best_for hints - scripts/partner_index/scan_partner_nodes.py: AST-based scanner that detects new API nodes in comfy_api_nodes/ (no runtime deps) - scripts/partner_index/build_partner_index.py: one-shot pipeline (scan -> merge node-centric index -> enhance decision fields) - scripts/partner_index/data/: extraction data + scan snapshot - package.json: partner:index:scan / build / verify commands
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Contributor
❌ Template Validation Failed |
Contributor
🔤 Spellcheck Results
|
CI template scanners (sync_bundles.py, validate_templates.py) treat every *.json under templates/ as a workflow template and fail on unmapped files. The partner node index is not a workflow template, so it lives at the repo root alongside bundles.json/nx.json. Build script output path updated.
- scan_partner_nodes: AST check IO.Schema(is_deprecated=True) -> deprecated flag on scan entries - build_partner_index: drop deprecated nodes on merge (232 -> 216); verify asserts zero deprecated residue - node_capabilities.py (new): node-level capability inference; strip model-spec tiers (resolution/format/size) when aggregating model options so nodes never claim specs only one model supports (e.g. GeminiNanoBanana2V2 Lite 1K vs 4K) - official_descriptions.py (new): official/community-sourced node description layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a node-centric index of ComfyUI partner API nodes for the in-app agent knowledge base (capability index → template library → node library), per the 8/6 in-app agent discussion.
Deliverable
templates/index.partner_node.json— 227 nodes (node_id / display_name / category / description / added_date), each with its model options (name, capabilities, released, recommended, is_latest, best_for). 40 nodes have model dropdowns (80 options); 22 nodes carryrecommended_models.Pipeline (self-contained in
scripts/partner_index/)scan_partner_nodes.py— AST-based scanner ofcomfy_api_nodes/*.py(no runtime deps). Idempotent full scan;--prevdiffs new nodes;--since <git-ref>counts nodes added after a ref. Detects nodes regardless of class-name suffix (e.g.IdeogramV3,TopazImageEnhance).build_partner_index.py— one-shot: scan → merge node-centric index → enhance (is_latest / pricing / best_for) → self-check (--verify).data/— extraction data + scan snapshot.npm commands
npm run partner:index:scan— re-scan nodes (detect new API nodes)npm run partner:index:build— full rebuildnpm run partner:index:verify— build + self-checkNotes