Skip to content

fix(minimax-h3): remove dangling <Audio 1> reference from R2V template prompt - #1139

Open
lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix/minimax-h3-r2v-audio-tag
Open

lin-bot23 wants to merge 1 commit into
Comfy-Org:mainfrom
lin-bot23:fix/minimax-h3-r2v-audio-tag

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

The R2V demo prompt was updated in #1137 to say "Use <Picture 2> and <Picture 1> as reference frames and <Audio 1> exactly as it is.", but no audio input is connected: ref_audios.ref_audio_0 has link None and the workflow has no LoadAudio node.

This is the same dangling-tag issue fixed in #1129 (docs#1386): the <Audio 1> reference silently no-ops when users run the template as-is.

Fix: restore the prompt to reference only the connected images. Syncs manifest accordingly.

Ref: Comfy-Org/docs#1447 (docs page documents the R2V tag system)

…e prompt

The R2V demo prompt referenced <Audio 1> but no audio input is connected
(ref_audios.ref_audio_0 is None). This is the same dangling-tag issue
fixed in Comfy-Org#1129; the reference silently no-ops when users run the template
as-is. Restore the prompt to reference only the connected images.
@github-actions

Copy link
Copy Markdown
Contributor

🔤 Spellcheck Results

Check Status
templates/index.json (titles & descriptions) ✅ No issues found
Workflow JSON notes (MarkdownNote / Note nodes) ✅ No issues found

All spellchecks passed! 🎉

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cc3b737f-cf8d-4eae-8667-fc9fde301213

📥 Commits

Reviewing files that changed from the base of the PR and between 021a8bc and 10ba9f9.

📒 Files selected for processing (2)
  • packages/core/src/comfyui_workflow_templates_core/manifest.json
  • templates/video_minimax_h3_r2v.json

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Minimax video workflow prompt no longer requires <Audio 1> to remain exactly unchanged. The manifest checksum was updated to match the modified workflow.

Changes

Minimax video workflow

Layer / File(s) Summary
Update workflow prompt and checksum
templates/video_minimax_h3_r2v.json, packages/core/src/comfyui_workflow_templates_core/manifest.json
The prompt removes the exact Audio 1 preservation instruction. The manifest now contains the replacement checksum for the workflow.

Suggested reviewers: comfyui-wiki

Merge Risk: ⚪ Minimal · up to 10ba9

The template now references only connected image inputs and keeps its manifest synchronized. No actionable merge-blocking risk remains after normal validation.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant