Skip to content

Add duplicate thumbnail validation - #1190

Draft
benceruleanlu wants to merge 2 commits into
mainfrom
bl/duplicate-thumbnail-check
Draft

benceruleanlu wants to merge 2 commits into
mainfrom
bl/duplicate-thumbnail-check

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Aug 25, 2026

Copy link
Copy Markdown
Member

Summary

  • add a lightweight pair-based checker for byte-identical and visually equivalent thumbnails across distinct templates
  • resolve explicit image thumbnail paths and implicit template-N.webp assets while ignoring multiple assets owned by one template
  • add a changed-files/base-ref CI gate so unrelated legacy duplicates do not block PRs
  • document the local commands and require the check in AGENTS.md for thumbnail changes

Measurements

  • current corpus: 597 templates and 767 effective image thumbnails
  • audit runtime: 2.33 to 2.52 seconds locally, median 2.36 seconds
  • existing debt: 3 cross-template pairs, consisting of 1 byte-identical and 2 visually equivalent pairs
  • the MiniMax and Nano Banana regressions are both detected despite different byte hashes

Validation

  • 6 focused tests passed
  • Ruff lint and format checks passed
  • Python compilation passed
  • workflow YAML parsed successfully
  • audit mode reports all 3 legacy pairs without failing
  • base-ref mode ignores unrelated legacy pairs and fails with actionable template IDs and asset paths for a newly affected duplicate

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant