Conversation
…itemap index comfy.org/sitemap.xml has 404ed since apps/website took over the root (Framer is gone; the Astro site emits /sitemap-index.xml + /sitemap-0.xml and robots.txt points there). The customSitemaps entry made /sitemap-workflows-index.xml advertise that 404 as a child, and validate-sitemap.ts HEAD-checks every <loc>, failing the SEO Audit job. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Astro sitemap configuration no longer includes Framer's marketing sitemap. It retains the ChangesSitemap integration
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This localized sitemap-reference cleanup does not introduce a concrete correctness, security, availability, or deployment risk and is merge-ready after normal checks; the separately described smoke-test refresh is not part of the current file change. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Internal Link Check✅ Nav-generated and hub-page internal links all resolve to real routes. Generated by Link Checker workflow |
🧹 Lint & Format Results
Generated by Site CI workflow |
🔍 SEO Audit Results
📊 SEO Audit Details7919 pages scanned, 4652 clean, 3267 with issues
Most common issues:
🔗 Link Check Details42047 broken internal links out of 42047 checked Generated by Site CI workflow |
|
🚀 Preview deployed: https://workflow-templates-5jc4whoy6-comfyui.vercel.app |
mobeenabdullah
left a comment
There was a problem hiding this comment.
Reviewed this properly and tested it locally. The sitemap change is correct. Two notes, neither blocking the fix itself.
The fix is right, and it is the only thing failing that script.
On this PR's own SEO Audit run, validate:sitemap logs Checking 1413 unique URLs... ✓ 1413 URLs accessible and Sitemap validation passed!. On today's run for #1223, whose head still carries the entry, the same script logs ✗ 1 URLs failed: https://comfy.org/sitemap.xml Status: 404 out of 8163 checked, and that entry is the only failure. I also rebuilt this merged with current main, since the branch is 17 commits behind and main has rewritten this config block since: build clean, the emitted sitemap-workflows-index.xml is just <loc>https://comfy.org/sitemap-workflows-0.xml</loc>, and verify:sitemap-indexability passes.
The premise in the description does not hold though: that step does not fail on it.
site-ci.yml:284 is if pnpm validate:sitemap 2>&1 | tee sitemap-output.txt; then, and the seo-audit job sets no shell: (there is none in the file), so it runs under the default bash -e with no pipefail and the if tests tee rather than pnpm. So status=passed is always written, and the Fail if critical issues step's only hard-fail path, if [ "${{ steps.sitemap.outputs.status }}" = "failed" ], is unreachable. #1223's run is the proof: the script logged ELIFECYCLE Command failed with exit code 1 and the check still reported pass with Sitemap Validation | ✅ passed.
The step right below it has the same issue, visible on this PR: audit:seo printed ❌ SEO audit FAILED - 11 critical issue(s) found and exited 1, under a reported SEO Audit | ✅ passed.
None of that blocks this PR. It just means merging fixes a real dead entry without turning any check green. Worth a follow-up adding pipefail (or shell: bash) to that job, though it needs care: validate-sitemap.ts HEAD-checks the absolute production URL in each <loc>, so once the gate can actually fail, a PR that adds a new page would fail it until that page is live.
Title claims a smoke-test refresh that is not in the diff.
The diff is only astro.config.mjs. This repo is squash-only with squash_merge_commit_title: PR_TITLE, and every recent main commit follows <PR title> (#N), so this title becomes main's permanent commit subject. Either apply the smoke-test patch here or retitle to the sitemap fix alone and open a follow-up for seo-smoke-test.yml.
The patch itself checks out. All three current expectations are stale as described (/templates/ 301, /templates/flux_schnell 301, sitemap-templates-index.xml 404), and every URL and header it switches to passes live today: /workflows/model/flux/ canonical is https://comfy.org/workflows/model/flux/, /workflows/ 200, sitemap-workflows-index.xml 200, workflow-templates.vercel.app/workflows/model/flux/ canonical points at comfy.org, and x-served-by is vercel-workflows and vercel-website.
mobeenabdullah
left a comment
There was a problem hiding this comment.
Approving the sitemap change at 3c38352a. It is correct, and I verified it rebuilt against current main: clean build, the emitted index is just sitemap-workflows-0.xml, and verify:sitemap-indexability passes.
One ask before merge: please retitle to the sitemap fix alone, or apply the smoke-test patch. Squash subjects land verbatim here (checked the last six merges, all are <PR title> (#N)), so the current title would enter main claiming a refresh this diff does not contain.
The pipefail point in my earlier comment is a pre-existing repo issue, not yours, and is not a condition of this approval.
Why
https://comfy.org/sitemap.xmlhas returned 404 since apps/website took over the comfy.org root (Framer is gone; the Astro marketing site emits/sitemap-index.xml+/sitemap-0.xml, and robots.txt points crawlers there). Two consequences in this repo:customSitemaps: ['https://comfy.org/sitemap.xml']makes our/sitemap-workflows-index.xmladvertise that 404 as its first child — verified live. Google reads a dead child sitemap from us, andvalidate-sitemap.tsHEAD-checks every<loc>, which is why the SEO Audit job's sitemap step fails./templates/returning 200 (it 301s to/workflows/now), the pre-renamesitemap-templates-index.xmlfilename, and the homepage being served by Framer (it'sx-served-by: vercel-websitenow).What
customSitemapsentry (this PR). Marketing pages are already covered by the root/sitemap-index.xmlchain, so nothing is lost.workflowscope for.github/workflows/*). The verified patch is below — every new expectation curl-checked live today; a maintainer can apply it here or in a follow-up:🤖 Generated with Claude Code