Skip to content

fix(site): render placeholder-video workflows with a poster image and… - #1233

Open
balpreetgrowthnatives wants to merge 4 commits into
mainfrom
fix/site-suppress-placeholder-video-indexing
Open

balpreetgrowthnatives wants to merge 4 commits into
mainfrom
fix/site-suppress-placeholder-video-indexing

Conversation

@balpreetgrowthnatives

Copy link
Copy Markdown
Collaborator

Summary

Google Search Console flags ~553 workflow pages with "Video isn't on a watch page" because they all embed the same placeholder video (comfy-hub-assets.comfy.org/uploads/850ff161-2547-4fce-a9c3-7835eeeedcce.mp4) that the hub serves when a workflow has no real preview yet.

This PR detects that placeholder asset and, while the real preview is missing:

  • renders its poster image instead of a <video> — on the detail hero (ThumbnailDisplay) and every grid card (HubWorkflowCard)
  • adds max-video-preview:0 to the detail page's robots meta (merged into the single existing robots tag, so noindex pages become noindex,follow,max-video-preview:0)

Files changed

File Change
site/src/lib/media-utils.ts new isPlaceholderVideo(url) + PLACEHOLDER_VIDEO_IDS
site/src/components/SEOHead.astro new suppressVideoIndexing prop → max-video-preview:0, merged into one <meta name="robots">
site/src/layouts/BaseLayout.astro pass suppressVideoIndexing through to SEOHead
site/src/components/ThumbnailDisplay.astro placeholder primary/secondary video → poster <img>; real videos unchanged
site/src/components/hub/HubWorkflowCard.vue placeholder video card → poster <img>, never <video>
site/src/pages/workflows/[slug].astro compute + pass suppressVideoIndexing
site/src/pages/[locale]/workflows/[slug].astro compute + pass suppressVideoIndexing (alongside existing noindex gating)
site/tests/unit/media-utils.test.ts +11 isPlaceholderVideo cases
site/tests/unit/seohead-render.test.ts +4 robots-meta merge/emit cases
site/tests/unit/thumbnail-display-placeholder.test.ts new — placeholder → <img>/no <video>; real → <video>

… max-video-preview:0 so Google stops flagging them as non-watch pages
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🧹 Lint & Format Results

Check Status
ESLint ✅ success
Prettier ✅ success

Generated by Site CI workflow

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 3dddeeba-bafc-474b-af3b-18384f20bf8b

📥 Commits

Reviewing files that changed from the base of the PR and between 2fe5fa7 and a8b979a.

📒 Files selected for processing (5)
  • site/src/components/SEOHead.astro
  • site/src/layouts/BaseLayout.astro
  • site/src/pages/[locale]/workflows/[slug].astro
  • site/src/pages/workflows/[slug].astro
  • site/tests/unit/seohead-render.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

Placeholder videos are detected through a shared media utility. Thumbnail components render placeholder videos as poster images. Workflow pages suppress video previews when no real video exists, and SEO metadata carries that setting through the layout.

Changes

Placeholder video handling and indexing

Layer / File(s) Summary
Placeholder detection and thumbnail rendering
site/src/lib/media-utils.ts, site/src/components/ThumbnailDisplay.astro, site/src/components/hub/HubWorkflowCard.vue, site/tests/unit/media-utils.test.ts, site/tests/unit/thumbnail-display-placeholder.test.ts
The site identifies shared placeholder videos and renders them as poster images. Real preview videos retain video playback. Tests cover URL normalization and rendering behavior.
Workflow indexing and SEO propagation
site/src/pages/.../workflows/[slug].astro, site/src/layouts/BaseLayout.astro, site/src/components/SEOHead.astro, site/tests/unit/seohead-render.test.ts
Workflow pages suppress video previews when only placeholder media exists. BaseLayout forwards the flag, and SEOHead combines the resulting robots directives.

Sequence Diagram(s)

sequenceDiagram
  participant WorkflowPage
  participant BaseLayout
  participant SEOHead
  WorkflowPage->>BaseLayout: pass suppressVideoPreview
  BaseLayout->>SEOHead: forward suppressVideoPreview
  SEOHead->>SEOHead: assemble robots directives
  SEOHead-->>WorkflowPage: render robots metadata
Loading

Merge Risk: ⚪ Minimal · up to f009c

Placeholder workflow previews render as poster images, while real videos retain video rendering and indexing-preview behavior. Robots metadata now limits video preview snippets only when no real preview exists, without changing existing noindex behavior.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/site-suppress-placeholder-video-indexing
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/site-suppress-placeholder-video-indexing

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🔗 Internal Link Check

✅ Nav-generated and hub-page internal links all resolve to real routes.


Generated by Link Checker workflow

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployed: https://workflow-templates-7vhaq0dmw-comfyui.vercel.app

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

⚡ Lighthouse Results

URL Performance Accessibility Best Practices SEO
/workflows/ 🟠 60 🟢 95 🟢 96 🟢 100
/workflows/ 🟠 86 🟢 95 🟢 96 🟢 100
/workflows/ 🟠 85 🟢 95 🟢 96 🟢 100
/workflows/use-cases/ 🟢 98 🟢 92 🟢 96 🟢 100
/workflows/use-cases/ 🟢 99 🟢 92 🟢 96 🟢 100
/workflows/use-cases/ 🟢 99 🟢 92 🟢 96 🟢 100
/workflows/use-cases/ai-anime-generator/ 🟢 91 🟢 93 🟢 96 🟢 100
/workflows/use-cases/ai-anime-generator/ 🟠 89 🟢 93 🟢 96 🟢 100
/workflows/use-cases/ai-anime-generator/ 🟠 75 🟢 93 🟢 96 🟢 100
/workflows/video_ltx2_3_i2v-7cc1d3bd2802/ 🟠 85 🟢 91 🟢 96 🟢 100
/workflows/video_ltx2_3_i2v-7cc1d3bd2802/ 🟠 81 🟢 91 🟢 96 🟢 100
/workflows/video_ltx2_3_i2v-7cc1d3bd2802/ 🟠 88 🟢 91 🟢 96 🟢 100

Scores are out of 100. 🟢 90+ | 🟠 50-89 | 🔴 0-49


Generated by Site CI workflow

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🔍 SEO Audit Results

Check Status
Sitemap Validation ✅ passed
SEO Audit ✅ passed
Internal Links ❌ failed
📊 SEO Audit Details

8561 pages scanned, 5245 clean, 3316 with issues

Severity Count
✖ Critical 12
⚠ Warning 4204
ℹ Info 1

Most common issues:

  • Meta description too short (N chars...) (×2410)
  • Title too short (N chars...) (×938)
  • Meta description too long (N chars...) (×608)
  • Title too long (N chars...) (×235)
  • Missing (×12)
🔗 Link Check Details

44412 broken internal links out of 44412 checked


Generated by Site CI workflow

…rrect its docs

max-video-preview:0 limits the video preview snippet, it does not
prevent page or video indexing. Rename the prop and reword the
JSDoc / comments to say so; no behavior change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant