fix(site): render placeholder-video workflows with a poster image and… - #1233
balpreetgrowthnatives wants to merge 4 commits into
Conversation
… max-video-preview:0 so Google stops flagging them as non-watch pages
🧹 Lint & Format Results
Generated by Site CI workflow |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughPlaceholder videos are detected through a shared media utility. Thumbnail components render placeholder videos as poster images. Workflow pages suppress video previews when no real video exists, and SEO metadata carries that setting through the layout. ChangesPlaceholder video handling and indexing
Sequence Diagram(s)sequenceDiagram
participant WorkflowPage
participant BaseLayout
participant SEOHead
WorkflowPage->>BaseLayout: pass suppressVideoPreview
BaseLayout->>SEOHead: forward suppressVideoPreview
SEOHead->>SEOHead: assemble robots directives
SEOHead-->>WorkflowPage: render robots metadata
Merge Risk: ⚪ Minimal · up to Placeholder workflow previews render as poster images, while real videos retain video rendering and indexing-preview behavior. Robots metadata now limits video preview snippets only when no real preview exists, without changing existing noindex behavior. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
🔗 Internal Link Check✅ Nav-generated and hub-page internal links all resolve to real routes. Generated by Link Checker workflow |
|
🚀 Preview deployed: https://workflow-templates-7vhaq0dmw-comfyui.vercel.app |
⚡ Lighthouse Results
Scores are out of 100. 🟢 90+ | 🟠 50-89 | 🔴 0-49 Generated by Site CI workflow |
🔍 SEO Audit Results
📊 SEO Audit Details8561 pages scanned, 5245 clean, 3316 with issues
Most common issues:
🔗 Link Check Details44412 broken internal links out of 44412 checked Generated by Site CI workflow |
…rrect its docs max-video-preview:0 limits the video preview snippet, it does not prevent page or video indexing. Rename the prop and reword the JSDoc / comments to say so; no behavior change.
Summary
Google Search Console flags ~553 workflow pages with "Video isn't on a watch page" because they all embed the same placeholder video (
comfy-hub-assets.comfy.org/uploads/850ff161-2547-4fce-a9c3-7835eeeedcce.mp4) that the hub serves when a workflow has no real preview yet.This PR detects that placeholder asset and, while the real preview is missing:
<video>— on the detail hero (ThumbnailDisplay) and every grid card (HubWorkflowCard)max-video-preview:0to the detail page'srobotsmeta (merged into the single existing robots tag, sonoindexpages becomenoindex,follow,max-video-preview:0)Files changed
site/src/lib/media-utils.tsisPlaceholderVideo(url)+PLACEHOLDER_VIDEO_IDSsite/src/components/SEOHead.astrosuppressVideoIndexingprop →max-video-preview:0, merged into one<meta name="robots">site/src/layouts/BaseLayout.astrosuppressVideoIndexingthrough toSEOHeadsite/src/components/ThumbnailDisplay.astro<img>; real videos unchangedsite/src/components/hub/HubWorkflowCard.vue<img>, never<video>site/src/pages/workflows/[slug].astrosuppressVideoIndexingsite/src/pages/[locale]/workflows/[slug].astrosuppressVideoIndexing(alongside existing noindex gating)site/tests/unit/media-utils.test.tsisPlaceholderVideocasessite/tests/unit/seohead-render.test.tssite/tests/unit/thumbnail-display-placeholder.test.ts<img>/no<video>; real →<video>