Skip to content

Fix epoch interval visibility toggles and serialization crash - #2

Open
CommanderPho wants to merge 1 commit into
developfrom
fix-epoch-interval-visibility-toggles-8275855279165487596
Open

Fix epoch interval visibility toggles and serialization crash#2
CommanderPho wants to merge 1 commit into
developfrom
fix-epoch-interval-visibility-toggles-8275855279165487596

Conversation

@CommanderPho

@CommanderPho CommanderPho commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Fix epoch interval visibility toggles, serialization crash, and incorrect pen colors in Spike3D app.


PR created automatically by Jules for task 8275855279165487596 started by @CommanderPho

Summary by Sourcery

Improve epoch interval rendering to support per-epoch visibility and correct color configuration.

New Features:

  • Add per-epoch visibility support by propagating an isVisible property through dataframe visualization columns into IntervalRectsItem rendering.

Bug Fixes:

  • Fix incorrect visibility toggling for multi-epoch series by removing global rect_item visibility updates and relying on per-epoch visibility flags.
  • Correct pen color assignment for Bapun epoch intervals to use lap_color instead of lap_accent_color.
  • Prevent crashes during epoch serialization/rendering by handling optional label and visibility fields robustly when building IntervalRectsItemData objects.

Enhancements:

  • Refine dataframe visualization update logic to directly assign visualization columns and derive labels from name when needed.
  • Extend IntervalRectsItem to handle both legacy tuple data and new IntervalRectsItemData objects with optional visibility and labels.

- Add `isVisible` to `IntervalRectsItemData` and update `generatePicture` to respect it, allowing per-epoch visibility.
- Fix QPen serialization crash by properly checking kwargs without mutating them.
- Ensure existing epoch labels are not overwritten with generic series names.
- Update `build_bapun_proper_epoch_intervals` to use `lap_color` instead of uniform `lap_accent_color`.

Co-authored-by: CommanderPho <962210+CommanderPho@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sourcery-ai

sourcery-ai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Reviewer's Guide

Refactors epoch interval rendering to drive per-rectangle visibility and styling directly from dataframe columns, adds support for item-level visibility in IntervalRectsItem, fixes label propagation and pen/brush defaults, and corrects lap color selection in PendingNotebookCode.

File-Level Changes

Change Details Files
Delegate visibility control to dataframe-driven properties instead of using rect_item.setVisible on IntervalRectsItem containers.
  • Remove post-update calls that applied visibility via rect_item.setVisible in update_rendered_intervals_visualization_properties.
  • Remove rect_item.setVisible-based visibility handling when reusing IntervalRectsItem instances in perform_update_epoch_interval_render_configs_from_configs.
  • Document that IntervalRectsItem now respects per-row visibility from its data and that container-level visibility toggling would break multi-epoch series.
src/pyphoplacecellanalysis/GUI/PyQtPlot/Widgets/Mixins/RenderTimeEpochs/EpochRenderingMixin.py
Extend dataframe visualization update helper to support explicit visibility, label handling, and direct overrides without mutating kwargs.
  • Add isVisible parameter support and map it onto an isVisible column, broadcasting scalars or copying sequences.
  • Stop writing visualization columns using kwargs.setdefault and instead assign directly, while still honoring incoming columns when provided via kwargs.
  • Simplify label handling to prefer explicit label argument, fall back to name when no label column exists, and avoid depending on label being present in active_df.
  • Ensure pen, brush, series_vertical_offset, and series_height respect either explicit parameters or overrides present in kwargs.
src/pyphoplacecellanalysis/GUI/PyQtPlot/Widgets/Mixins/RenderTimeEpochs/Specific2DRenderTimeEpochs.py
Propagate optional label and per-item visibility from dataframes into IntervalRectsItemData instances when building render tuples.
  • Validate required base columns, then compute per-row IntervalRectsItemData construction using iterrows.
  • Include label and isVisible fields conditionally when those columns exist in the dataframe.
  • Return a list of IntervalRectsItemData objects instead of plain tuples, while remaining compatible with existing consumers that expect the sequence shape.
src/pyphoplacecellanalysis/GUI/PyQtPlot/Widgets/Mixins/RenderTimeEpochs/Render2DEventRectanglesHelper.py
Teach IntervalRectsItem to understand per-item visibility while remaining backwards compatible with tuple-based data.
  • Add isVisible boolean field with default True to IntervalRectsItemData dataclass.
  • Update generatePicture to iterate over self.data items, unpacking either legacy tuples or IntervalRectsItemData objects.
  • Skip drawing any item whose isVisible flag is False, while continuing to draw others in the same series.
src/pyphoplacecellanalysis/GUI/PyQtPlot/Widgets/GraphicsObjects/IntervalRectsItem.py
Correct lap interval pen color source to use the main lap color rather than the accent color in bapun epoch construction.
  • Change pen_color computation in build_bapun_proper_epoch_intervals to derive from lap_color instead of lap_accent_color.
  • Keep brush_color, y_location, and height assignments unchanged to maintain existing appearance aside from the pen color fix.
src/pyphoplacecellanalysis/SpecificResults/PendingNotebookCode.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant