Skip to content

Update deprecated ghcr.io image reference to public.ecr.aws - #35

Open
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references
Open

Update deprecated ghcr.io image reference to public.ecr.aws#35
luisina-santos wants to merge 1 commit into
mainfrom
luisinasantos/fix-ghcr-image-references

Conversation

@luisina-santos

Copy link
Copy Markdown
Contributor

Summary

  • README.md referenced this connector's image via ghcr.io/conductorone/baton-jumpcloud:latest; container images are now published to public.ecr.aws/conductorone/baton-jumpcloud:latest instead.
  • Only this connector's own image reference was updated.
  • Related audit: CXH-2418.

Test plan

  • Verified public.ecr.aws/conductorone/baton-jumpcloud:latest resolves (manifest exists) before opening this PR.
  • Diff reviewed — only the image domain changed.

🤖 Generated with Claude Code

README.md referenced this connector's image via ghcr.io/conductorone;
container images are now published to public.ecr.aws/conductorone
instead. Only this connector's own image reference was updated.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Connector PR Review: Update deprecated ghcr.io image reference to public.ecr.aws

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base e8b95ba58fee.
Review mode: full
View review run

Review Summary

The full PR diff was scanned for security and correctness: it is a single-line documentation change in README.md swapping this connector's docker image registry from ghcr.io/conductorone/baton-jumpcloud:latest to public.ecr.aws/conductorone/baton-jumpcloud:latest. No Go source, go.mod/go.sum, config, or provisioning code changed, so no connector implementation, dependency, or breaking-change criteria apply. The new reference matches what docs/connector.mdx:197 already documents, so the docs stay consistent and no staleness update is needed.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • README.md:23 — the adjacent baton CLI example still pulls the baton CLI image from ghcr.io/conductorone/baton:latest; if that image also moved to public.ecr.aws, the two lines in the same code block will drift. Low confidence, and explicitly out of this PR's stated scope since the baton CLI image is owned by another repo, so this is informational only.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 23: The second docker example still pulls the baton CLI from the old
  registry `ghcr.io/conductorone/baton:latest`. If the conductorone/baton CLI image is
  also published to `public.ecr.aws/conductorone/baton:latest`, update this line to that
  reference so both examples in the same code block use the same registry. Confirm the
  manifest exists at `public.ecr.aws/conductorone/baton:latest` first; if it does not,
  leave the line unchanged.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant