feat(compliance): require a note on AML decisions and record it in the KYC log - #1277
Draft
Blume1977 wants to merge 1 commit into
Draft
feat(compliance): require a note on AML decisions and record it in the KYC log#1277Blume1977 wants to merge 1 commit into
Blume1977 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AML decision form (compliance review, tab "AML Pending") gets a mandatory note field, analogous to the call-queue outcome form: the clerk records the reasoning for the release/rejection, and it is appended to the KYC log entry (
comment:section ofbuildKycLogMessage), for Pass/Fail/Pending as well as Reset.Deliberately NOT written to the transaction
commentcolumn: that column carries the AML error list (e.g.ScorechainHighRisk), which the release mechanism in the API matches on (DFXswiss/api#4654, DFXswiss/api#4402) — free text there would break it.The save button stays disabled until decision, editor and note are filled in.