Release: develop -> main - #144
Merged
Merged
Conversation
#143) * Restore FAQ hash scrolling dropped by the .html path rewrite VuePress maps /de/faq to /de/faq.html and strips the fragment, so deep links never leave the top of the page. Keep the original hash and scroll to it after the router is ready. Give the Trade Republic heading a stable id. * Use an HTML id for the Trade Republic FAQ heading VuePress 1.5 ships markdown-it-anchor 5, which does not parse {#custom-id}. A raw anchor keeps a stable #trade-republic without rendering the braces in the heading. * Put the FAQ hash back in the URL and retry after client navigation After the .html rewrite, restore the fragment with replaceState so reload and copy-paste still work. Scroll again on afterEach for in-app FAQ links, skip a broken percent-encoding, and aim at the next sibling when the empty id anchor has no box. * Restore the hash only after the target exists replaceState after a successful lookup so a dropped fragment is not written onto the next page. Chain the retries and name the navbar offset. In-app header-anchor clicks stay on VuePress. * Note that the faq.html rewrite applies in every locale * Scroll after Vue Router's initial reset and keep history.state Always queue a 0ms retry so handleScroll cannot leave the page at y=0. Keep history.state in replaceState. Ignore the stored hash if the path has already changed. --------- Co-authored-by: TaprootFreakAI <315477232+TaprootFreakAI@users.noreply.github.com>
TaprootFreak
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic Release PR
This PR was automatically created after changes were pushed to develop.
Commits: 1 new commit(s)
Checklist