Skip to content

Remove a dead element-code check in MeshFile, and record why node Z is float64 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ecomodeller wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove a dead element-code check in MeshFile, and record why node Z is float64 #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions mikecore/MeshFile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,13 @@ def Read(self, filename:str):
self.NodeIds = np.zeros(noNodes, dtype=np.int32)
self.X = np.zeros(noNodes, dtype=np.float64)
self.Y = np.zeros(noNodes, dtype=np.float64)
self.Z = np.zeros(noNodes, dtype=np.float64) # TODO or np.float32 ?
# float64 is correct here, and deliberate. A .mesh stores coordinates
# as text, so the file imposes no width and can carry more precision
# than float32 holds. MeshBuilder.SetNodes narrows Z to float32
# because that is the path towards a dfsu, where node Z occupies four
# bytes; reading a file is not that path. Narrowing here would
# silently drop digits the file actually contains.
self.Z = np.zeros(noNodes, dtype=np.float64)
self.Code = np.zeros(noNodes, dtype=np.int32)

# Read nodes
Expand Down Expand Up @@ -275,10 +281,10 @@ def Read(self, filename:str):
except Exception as ex:
raise Exception("Can not load mesh file (failed reading element header line): {0}. {1}".format(filename, ex))

# Element code must be 21 or 25 (21 for triangular meshes, 25 for mixed meshes)
if (elmtCode != 21) or (elmtCode != 25):
pass # TODO?? Do we care?
# elmtCode is the element code from the header: 21 for a triangular
# mesh, 25 for a mixed one. It is read but not acted on; ElementType
# is derived per element from the corner count below.

# Allocate memory for elements
self.ElementIds = np.zeros(noElements, dtype=np.int32)
self.ElementType = np.zeros(noElements, dtype=np.int32)
Expand Down
Loading