Skip to content

Fix integration test, no longer producing ADC patterns for CRT - #337

Merged
xinyue-uoft merged 1 commit into
developfrom
theo/crt_patterngen_fix
Aug 25, 2026
Merged

Fix integration test, no longer producing ADC patterns for CRT#337
xinyue-uoft merged 1 commit into
developfrom
theo/crt_patterngen_fix

Conversation

@xinyue-uoft

@xinyue-uoft xinyue-uoft commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Description

See DUNE-DAQ/datahandlinglibs#145 . datahandlinglibs function generate_periodic_adc_pattern is currently trying to distribute ADC pattern over 64 frames over CRT which has only 32 frames. Only thing preventing an runtime error is a blind try-catch statement. The correct behaviour should be that ADC pattern generation for CRTs should not be there in the first place. This PR changes it at integration test config substitution level to disable ADC pattern generation on CRT.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

@bieryAtFnal bieryAtFnal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
I confirmed that, with this change, the system doesn't crash when I locally modify the SourceEmulatorModel code as Theo described and run the readout_type_scan_test.
And, I've verified that the configuration is different in the way that we expect, when I use this change.

@xinyue-uoft
xinyue-uoft merged commit 26bf5ec into develop Aug 25, 2026
6 checks passed
@xinyue-uoft
xinyue-uoft deleted the theo/crt_patterngen_fix branch August 25, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants