Skip to content

👷 Sync rum-events-format schemas for session replay image content - #5017

Draft
BeltranBulbarellaDD wants to merge 2 commits into
mainfrom
beltran.bulbarella/sync-rum-events-format
Draft

👷 Sync rum-events-format schemas for session replay image content#5017
BeltranBulbarellaDD wants to merge 2 commits into
mainfrom
beltran.bulbarella/sync-rum-events-format

Conversation

@BeltranBulbarellaDD

@BeltranBulbarellaDD BeltranBulbarellaDD commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Motivation

Synchronize the Browser SDK with the latest rum-events-format schema so session replay can represent image content changes and resource IDs consistently.

Changes

  • Bump @datadog/rum-events-format to the schema revision containing:
    • ImageContentChange session replay changes.
    • StringResourceId string role.
    • WASM stack-trace symbolication fields.
  • Regenerate the schema-derived TypeScript types.
  • Add the corresponding SDK ChangeType.ImageContent and StringRole.ResourceId constants.
  • Update string ID handling and change encoding/decoding for image resource IDs.
  • Add a decoder regression test for image content resource references.

Test instructions

Run:

yarn typecheck
yarn test:unit --spec packages/browser-rum/src/domain/record/encoding/changeDecoder.spec.ts

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 4, 2026

Copy link
Copy Markdown

Tests

All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 77.10% (+0.01%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5863a93 | Docs | View more details | Give us feedback!

@BeltranBulbarellaDD BeltranBulbarellaDD changed the title Run json-schemas:sync to sync rum events format 👷 Run json-schemas:sync to sync rum events format Sep 4, 2026
@BeltranBulbarellaDD BeltranBulbarellaDD changed the title 👷 Run json-schemas:sync to sync rum events format 👷 Sync rum-events-format schemas for session replay image content Sep 4, 2026
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 182.14 KiB 182.14 KiB 0 B 0.00%
Rum Profiler 8.43 KiB 8.43 KiB 0 B 0.00%
Rum Recorder 28.22 KiB 28.27 KiB +46 B +0.16%
Logs 57.96 KiB 57.96 KiB 0 B 0.00%
Rum Salesforce N/A 140.20 KiB N/A N/A N/A
Rum Slim 140.20 KiB 140.20 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%
Rum Shopify N/A 209.90 KiB N/A N/A N/A
Rum-shopify Profiler N/A 8.43 KiB N/A N/A N/A
Rum-shopify Recorder N/A 3.74 KiB N/A N/A N/A

@BeltranBulbarellaDD

Copy link
Copy Markdown
Contributor Author

@codex review pls

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T17:39:03.458087Z 5863a93 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 5863a9345b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant