[WIP] Remove Datadog credentials from PR CI - #500
Draft
sdkennedy2 wants to merge 1 commit into
Draft
Conversation
sdkennedy2
changed the title
Collaborator
Author
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR-controlled test and build code currently receives a long-lived Datadog API key. This temporarily removes that credential exposure while an OIDC-based
dd-stsreplacement is designed and validated.Related context: PR #493 and incident 60148.
Changes
Temporarily disables Datadog Test Optimization for unit and end-to-end tests by removing the setup action and tracer injection. The lint build continues producing local build-report artifacts, but no longer receives an API key and therefore cannot submit build metrics to Datadog.
Trusted release workflows are intentionally unchanged. Test Optimization and PR build metrics will be restored separately using
dd-stsafter its trust policy and credential lifetime are validated.QA Instructions
Review the PR workflow run and confirm that the Unit tests, End to End, and Linting jobs still complete without a Datadog repository secret. No product-level manual QA is needed because this changes CI telemetry only.
Blast Radius
This affects only pull-request CI telemetry. Unit and end-to-end Test Optimization data and lint build metrics will be absent temporarily. Test execution, build-report artifacts, and trusted publish/bump workflows remain unchanged.
Documentation