[RBAC PR 6] Enforce mutation grants for governed namespaces - #2467
Draft
philipfweiss wants to merge 2 commits into
Draft
[RBAC PR 6] Enforce mutation grants for governed namespaces#2467philipfweiss wants to merge 2 commits into
philipfweiss wants to merge 2 commits into
Conversation
Derive restrictive WRITE, DELETE, and MANAGE rules from persisted namespace boundaries so provisioning activates exclusive RBAC without a deployment allowlist.
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
Treat hard deletion of a governed root as a MANAGE operation so a deployer cannot remove the persisted policy marker and reopen the namespace to fallback access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #2234 (step 6).
Provisioning a governed namespace records its owner and deployer grants, but those grants do not restrict anyone else while the default policy is permissive. An unassigned caller can still mutate nodes inside the namespace, so the ownership boundary is not enforced.
This PR makes
is_governed_boundaryenforce explicit grants for mutations:WRITE,DELETE, andMANAGErequire a matching grant on the boundary or its descendants.READ,EXECUTE, ungoverned namespaces, and the admin bypass keep their current behavior.MANAGE, since deletion removes its policy marker.The rule applies on upgrade to provisioned and creator-owned namespaces whose marker is already true. Legacy namespaces with a false marker remain unchanged until backfill and activation.
Verification:
Ran the in-memory HTTP app with
DEFAULT_ACCESS_POLICY=permissiveand no configured restrictive scopes. Provisionedexample.metricsfor owner groupownersand service accountdeploy-bot, then checked these paths: