Add value setter to Gedcom structure - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the authoring (serialization) ergonomics of the library by (1) making GedcomStructure easier to construct when building trees programmatically, and (2) adding a public set_value helper that writes correctly-formatted payload text from typed values using the structure’s resolved GEDCOM 7 type.
Changes:
- Add default values for
GedcomStructure.pointer,GedcomStructure.text, andGedcomStructure.xrefso onlytagis required for construction. - Introduce
gedcom7.set_value(structure, value, type_id=None)to format and assign payload text based on the resolved structure type (or an explicitly providedtype_id). - Add test coverage for constructor defaults and
set_valuebehavior (type resolution, explicit override, extension passthrough, booleanY|<NULL>semantics, and serializer round-trip).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_types.py | Adds tests validating new GedcomStructure constructor defaults and non-shared child lists. |
| test/test_format.py | Adds tests covering set_value resolution rules, error cases, and round-trip serialization. |
| gedcom7/types.py | Makes GedcomStructure’s pointer/text/xref optional via defaults for easier programmatic construction. |
| gedcom7/format.py | Adds set_value helper built on format_value and structure-type resolution. |
| gedcom7/init.py | Re-exports set_value as part of the public package API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.