Add validation module - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a first-pass dataset validation facility to gedcom7, exposing a validate() API and integrating optional pre-serialization validation into dumps().
Changes:
- Introduces
gedcom7.validatewith anErrormodel and avalidate(records)function to report multiple dataset issues in one pass. - Adds
GedcomValidationErrorand wiresserializer.dumps(..., validate=True)to raise it with all discovered problems. - Adds comprehensive tests covering dataset shape, pointers, payload kinds/values (incl. date sanity checks), schema declarations, and dumps validation behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/test_validate.py | Adds unit tests for the new validation behavior and dumps(validate=True) integration. |
| gedcom7/validate.py | Implements dataset validation (document shape, schema conflicts, payload checks, pointer checks, and date range sanity checks). |
| gedcom7/serializer.py | Adds validate option to dumps() and raises GedcomValidationError when validation fails. |
| gedcom7/exceptions.py | Introduces GedcomValidationError carrying all validation issues and summarizing them in the exception message. |
| gedcom7/init.py | Exports validate, Error, and GedcomValidationError as part of the public API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.