fix(float): don't latch isShowingDebuggerView when the debugger isn't ready - #448
Open
dimashbk wants to merge 1 commit into
Open
fix(float): don't latch isShowingDebuggerView when the debugger isn't ready#448dimashbk wants to merge 1 commit into
dimashbk wants to merge 1 commit into
Conversation
… ready presentDebugger() set the flag before the floatViewController nil-check; a call within the 1s setup window latched the flag forever - hidden ball, dead shake entry point, and CustomWindow hit-testing the whole screen with user interaction never re-enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WindowManager.presentDebugger()setsFloatViewManager.isShowingDebuggerView = truebefore nil-checkingfloatViewController. The controller is only assigned ~1s aftersetup()(deferred viaasyncAfterinFeatureHandling), so anypresentDebugger()call inside that window — a shake handler, a ball tap injected by UI tests — latches the flag with nothing presented and nothing ever resets it:didSetand never comes back;presentDebugger()dies on the guard;CustomWindow.point(inside:)returnstruefor the whole screen while the flag is set, andisUserInteractionEnabled = falseis only applied inside the skipped branch — the invisible window eats every touch and the host app becomes unresponsive until relaunch.Fix: check
floatViewControllerin the same guard and set the flag only when the debugger is actually presented.Type of change
Test plan
Manual test steps
DebugSwift.App.presentDebugger()within 1s ofsetup()(e.g. from a shake handler right after launch).Checklist