chore: add .editorconfig for consistent formatting - #324
Merged
Conversation
shfmt reads .editorconfig automatically, so CI will now enforce 4-space indent for shell scripts matching the org coding standards. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d78695b5-ded3-4a2c-9f2a-f30c77d7d188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
.editorconfigto standardize formatting across editors and CI tools.Problem
PR #240 fails the
lint / shfmtcheck becauseshfmtdefaults to tab indentation, while our org conventions specify 4-space indent for shell scripts. Without an.editorconfig, there's no single source of truth for formatting rules.Solution
shfmtautomatically reads.editorconfig, so this file ensures CI enforces 4-space indent for.shfiles — matching the org coding standards — without needing to pass-i 4flags in every workflow invocation.Settings applied
**.{yml,yaml,json}*.md*.shMakefileRelated
shfmtfailure in chore: materialize APM primitives #240.editorconfig