fix: arity checking of call expression arguments

src/evaluator/expression/call/mod.rs

@@ -10,6 +10,14 @@ impl Evaluator {
     ) -> anyhow::Result<Object> {
         match self.evaluate_expression(function)? {
             Object::Function { parameters, block } => {
+                if arguments.len() != parameters.len() {
+                    anyhow::bail!(
+                        "Wrong number of arguments, want={}, got={}.",
+                        parameters.len(),
+                        arguments.len()
+                    );
+                }
+
                 self.environment.push();
 
                 for (argument, parameter_identifier) in arguments.into_iter().zip(parameters) {

src/tests/evaluation_error/mod.rs

@@ -10,3 +10,4 @@ mod type_mismatch_integer_infix_expression;
 mod type_mismatch_integer_prefix_expression;
 mod uncallable_object;
 mod unknown_operator_integer_infix_expression;
+mod wrong_number_of_arguments;

src/tests/evaluation_error/wrong_number_of_arguments/mod.rs

@@ -0,0 +1,30 @@
+use super::*;
+
+#[template]
+#[rstest(
+    code,
+    snapshot_name,
+    case("fn(x, y) { x + y }(1);", "wrong_number_of_arguments_case_1"),
+    case(
+        "let add = fn(x, y) { x + y }; add(1, 2, 3);",
+        "wrong_number_of_arguments_case_2"
+    ),
+    case("fn(x) { x }();", "wrong_number_of_arguments_case_3"),
+    case("fn() { 5 }(1);", "wrong_number_of_arguments_case_4")
+)]
+fn wrong_number_of_arguments_cases(code: &str, snapshot_name: &str) {}
+
+#[apply(wrong_number_of_arguments_cases)]
+fn test_wrong_number_of_arguments_lexical_analysis(code: &str, snapshot_name: &str) {
+    assert_lexical_analysis!(code, snapshot_name);
+}
+
+#[apply(wrong_number_of_arguments_cases)]
+fn test_wrong_number_of_arguments_syntax_analysis(code: &str, snapshot_name: &str) {
+    assert_syntax_analysis!(code, snapshot_name);
+}
+
+#[apply(wrong_number_of_arguments_cases)]
+fn test_wrong_number_of_arguments_evaluation_error(code: &str, snapshot_name: &str) {
+    assert_evaluation_error!(code, snapshot_name);
+}

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_1_evaluation_error.snap

@@ -0,0 +1,7 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: error
+---
+Err(
+    "Wrong number of arguments, want=2, got=1.",
+)

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_1_lexical_analysis.snap

@@ -0,0 +1,31 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: tokens
+---
+[
+    Function,
+    OpeningRoundBracket,
+    Identifier {
+        literal: "x",
+    },
+    Comma,
+    Identifier {
+        literal: "y",
+    },
+    ClosingRoundBracket,
+    OpeningCurlyBracket,
+    Identifier {
+        literal: "x",
+    },
+    Plus,
+    Identifier {
+        literal: "y",
+    },
+    ClosingCurlyBracket,
+    OpeningRoundBracket,
+    Integer {
+        literal: 1,
+    },
+    ClosingRoundBracket,
+    SemiColon,
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_1_syntax_analysis.snap

@@ -0,0 +1,36 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: abstract_syntax_tree
+---
+[
+    Expression {
+        expression: Call {
+            function: Function {
+                parameters: [
+                    "x",
+                    "y",
+                ],
+                block: Block {
+                    nodes: [
+                        Expression {
+                            expression: Infix {
+                                left_hand: Identifier {
+                                    identifier: "x",
+                                },
+                                operator: Plus,
+                                right_hand: Identifier {
+                                    identifier: "y",
+                                },
+                            },
+                        },
+                    ],
+                },
+            },
+            arguments: [
+                Integer {
+                    literal: 1,
+                },
+            ],
+        },
+    },
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_2_evaluation_error.snap

@@ -0,0 +1,7 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: error
+---
+Err(
+    "Wrong number of arguments, want=2, got=3.",
+)

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_2_lexical_analysis.snap

@@ -0,0 +1,48 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: tokens
+---
+[
+    Let,
+    Identifier {
+        literal: "add",
+    },
+    Assign,
+    Function,
+    OpeningRoundBracket,
+    Identifier {
+        literal: "x",
+    },
+    Comma,
+    Identifier {
+        literal: "y",
+    },
+    ClosingRoundBracket,
+    OpeningCurlyBracket,
+    Identifier {
+        literal: "x",
+    },
+    Plus,
+    Identifier {
+        literal: "y",
+    },
+    ClosingCurlyBracket,
+    SemiColon,
+    Identifier {
+        literal: "add",
+    },
+    OpeningRoundBracket,
+    Integer {
+        literal: 1,
+    },
+    Comma,
+    Integer {
+        literal: 2,
+    },
+    Comma,
+    Integer {
+        literal: 3,
+    },
+    ClosingRoundBracket,
+    SemiColon,
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_2_syntax_analysis.snap

@@ -0,0 +1,50 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: abstract_syntax_tree
+---
+[
+    Statement {
+        statement: Let {
+            identifier: "add",
+            expression: Function {
+                parameters: [
+                    "x",
+                    "y",
+                ],
+                block: Block {
+                    nodes: [
+                        Expression {
+                            expression: Infix {
+                                left_hand: Identifier {
+                                    identifier: "x",
+                                },
+                                operator: Plus,
+                                right_hand: Identifier {
+                                    identifier: "y",
+                                },
+                            },
+                        },
+                    ],
+                },
+            },
+        },
+    },
+    Expression {
+        expression: Call {
+            function: Identifier {
+                identifier: "add",
+            },
+            arguments: [
+                Integer {
+                    literal: 1,
+                },
+                Integer {
+                    literal: 2,
+                },
+                Integer {
+                    literal: 3,
+                },
+            ],
+        },
+    },
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_3_evaluation_error.snap

@@ -0,0 +1,7 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: error
+---
+Err(
+    "Wrong number of arguments, want=1, got=0.",
+)

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_3_lexical_analysis.snap

@@ -0,0 +1,20 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: tokens
+---
+[
+    Function,
+    OpeningRoundBracket,
+    Identifier {
+        literal: "x",
+    },
+    ClosingRoundBracket,
+    OpeningCurlyBracket,
+    Identifier {
+        literal: "x",
+    },
+    ClosingCurlyBracket,
+    OpeningRoundBracket,
+    ClosingRoundBracket,
+    SemiColon,
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_3_syntax_analysis.snap

@@ -0,0 +1,25 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: abstract_syntax_tree
+---
+[
+    Expression {
+        expression: Call {
+            function: Function {
+                parameters: [
+                    "x",
+                ],
+                block: Block {
+                    nodes: [
+                        Expression {
+                            expression: Identifier {
+                                identifier: "x",
+                            },
+                        },
+                    ],
+                },
+            },
+            arguments: [],
+        },
+    },
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_4_evaluation_error.snap

@@ -0,0 +1,7 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: error
+---
+Err(
+    "Wrong number of arguments, want=0, got=1.",
+)

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_4_lexical_analysis.snap

@@ -0,0 +1,20 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: tokens
+---
+[
+    Function,
+    OpeningRoundBracket,
+    ClosingRoundBracket,
+    OpeningCurlyBracket,
+    Integer {
+        literal: 5,
+    },
+    ClosingCurlyBracket,
+    OpeningRoundBracket,
+    Integer {
+        literal: 1,
+    },
+    ClosingRoundBracket,
+    SemiColon,
+]

src/tests/evaluation_error/wrong_number_of_arguments/snapshots/monkey_interpreter__tests__evaluation_error__wrong_number_of_arguments__test_wrong_number_of_arguments_case_4_syntax_analysis.snap

@@ -0,0 +1,27 @@
+---
+source: src/tests/evaluation_error/wrong_number_of_arguments/mod.rs
+expression: abstract_syntax_tree
+---
+[
+    Expression {
+        expression: Call {
+            function: Function {
+                parameters: [],
+                block: Block {
+                    nodes: [
+                        Expression {
+                            expression: Integer {
+                                literal: 5,
+                            },
+                        },
+                    ],
+                },
+            },
+            arguments: [
+                Integer {
+                    literal: 1,
+                },
+            ],
+        },
+    },
+]