LIMS-2281: Simplify code between Synchweb and Shipping Service - #1090
Open
ndg63276 wants to merge 1 commit into
Open
LIMS-2281: Simplify code between Synchweb and Shipping Service#1090ndg63276 wants to merge 1 commit into
ndg63276 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-2281
Summary:
Remove the option to use the shipping service without redirection, so we can send the shipping service the external_id of null. This will get rid of the error when the same external_id gets reused for incoming and outgoing.
Changes:
elseclauses that are no longer in use_dispatch_dewar_in_shipping_serviceand_book_shipment_in_shipping_servicefunctions that are no longer accessibleTo test:
Go to any proposal (eg mx23694), go to /shipments/add and create a UDC shipment using a UK lab contact, and clicking "Use Facility Account"
Click Create DHL Air Waybill, then Proceed, then complete the shipping service form
Check the AWB number ends up in ISPyB, and the dewar status goes to "awb created" or "pickup booked"
Click "Dispatch" and then "Proceed", then complete the shipping service form
Check the return AWB number ends up in ISPyB, and the dewar status goes to "dispatch-booked"
Disable the shipping service in config