Preserve full-sweep HATCH boundary angles - #1237
Conversation
|
The methods that you are replacing do the same as the change, it seems a redundant change. |
|
Thanks for reviewing. I checked the exact CSUtilities revision pinned by ACadSharp ( For this full sweep:
The DXF reader only converts those values back with Would you consider reopening this PR? If you prefer, I can instead fix the unused |
|
I see, the issue then is in CSUtilities, it should allow the option for non absolute values in range of -360 to 360, reopening the PR. |
Description
HATCH arc and ellipse boundary angles were normalized independently while being converted from radians to degrees. A full sweep such as
-π/2to3π/2was consequently written as270to270, collapsing the boundary.This change converts those four boundary values without normalizing either endpoint. Other DXF angle writers are unchanged.
Tasks done in this PR
Related Issues / Pull Requests
Notes for reviewer
dotnet test ACadSharp.Tests/ACadSharp.Tests.csproj --framework net9.0 --filter FullyQualifiedName~DxfHatchWriterTests