Fix apex SRV apply validation after variable resolution - #44
Open
gudron533 wants to merge 1 commit into
Open
Conversation
Author
|
I also reproduced the same failure in the current Online Editor using the already-merged official bluehost.com.email.json template. Its _autodiscover._tcp SRV with name: "" fails with the same Invalid data for SRV host: __tcp.@ error. This confirms the regression affects an existing upstream template, not only the Mailvar draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Valid Domain Connect SRV records with
name: "@"fail during apply withInvalid data for SRV host: _tcp.@.The SRV processor resolves the name to the apex sentinel, but then validates a
synthetic
_<raw protocol>.@hostname.@is not a DNS label; it representsthe applied domain/host apex.
This check also runs before protocol variable resolution, preventing the
protocol/service variable conventions used by the official example template.
Fix
@sentinel when constructing the owner used for validation._service._protocol[.name]owner using the existingstrict SRV hostname validator.
InvalidData.No generic hostname validator is relaxed and canonical zone-record output is
unchanged.
Tests
Adds coverage for:
_sip._tlsapex SRV._autodiscover._tcpapex SRV.host=test.Also updates legacy tests that previously expected standards-compliant apex SRV
records to fail.
Full suite: 373 passed.