Conversation
Collaborator
Contributor
Author
Good call, I misunderstood low level drawing and size inheriting before, but after checking this is in fact a lot better. |
matt-hb
force-pushed
the
chapter-image-fallback
branch
3 times, most recently
from
September 28, 2026 16:34
1c83b3f to
c2835ac
Compare
TODO: Chapter Timeline widget
matt-hb
force-pushed
the
chapter-image-fallback
branch
from
September 28, 2026 22:19
c2835ac to
51cf167
Compare
Contributor
Author
|
I think the final implementation of the timeline is quite nice, do we think some people would prefer it over having an image for the chapters altogether? If so, I could add a toggle in the options to force it over the images, let me know. Thanks for all the work over the last couple months, btw! I haven't stopped using the client even though I've not had the time to contribute or finish a PR 😅 |
matt-hb
marked this pull request as ready for review
September 28, 2026 22:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request Description
First actual feature PR, chapter images (or lack thereof) have been bothering me a bunch so I'm implementing a trickplay fallback as per #875 .
Also added caching for trickplay images, because we're fetching them a bunch.
Issue Being Fixed
Placeholder when there are no chapter images available, either via fallback to trickplay images or a timeline if trickplay images are not available either.
Screenshots / Recordings
Before (yucky placeholders):

After (with trickplay fallback):

After (with timeline):
Tested On
Checklist