Skip to content

feat: Chapter image trickplay/timeline fallback - #963

Open
matt-hb wants to merge 3 commits into
DonutWare:developfrom
matt-hb:chapter-image-fallback
Open

matt-hb wants to merge 3 commits into
DonutWare:developfrom
matt-hb:chapter-image-fallback

Conversation

@matt-hb

@matt-hb matt-hb commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

Pull Request Description

First actual feature PR, chapter images (or lack thereof) have been bothering me a bunch so I'm implementing a trickplay fallback as per #875 .
Also added caching for trickplay images, because we're fetching them a bunch.

Issue Being Fixed

Placeholder when there are no chapter images available, either via fallback to trickplay images or a timeline if trickplay images are not available either.

Screenshots / Recordings

Before (yucky placeholders):
image

After (with trickplay fallback):
image

After (with timeline):

hovering a chapter fills the bar up to the selection with a nice animation

image

Tested On

  • Android
  • Android TV
  • Desktop
  • Web

Checklist

  • Check that any changes are related to the issue at hand.
  • Create timeline widget

@PartyDonut

Copy link
Copy Markdown
Collaborator

Just did a test for Android TV it's quite blurry. Does not look great to be honest.

Another solution would be to change the filterquality inside of the _TrickplayPainter from trick_play_image.dart

image

@matt-hb

matt-hb commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Another solution would be to change the filterquality inside of the _TrickplayPainter from trick_play_image.dart

Good call, I misunderstood low level drawing and size inheriting before, but after checking this is in fact a lot better.

@matt-hb
matt-hb force-pushed the chapter-image-fallback branch 3 times, most recently from 1c83b3f to c2835ac Compare September 28, 2026 16:34
@matt-hb
matt-hb force-pushed the chapter-image-fallback branch from c2835ac to 51cf167 Compare September 28, 2026 22:19
@matt-hb

matt-hb commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

I think the final implementation of the timeline is quite nice, do we think some people would prefer it over having an image for the chapters altogether? If so, I could add a toggle in the options to force it over the images, let me know.

Thanks for all the work over the last couple months, btw! I haven't stopped using the client even though I've not had the time to contribute or finish a PR 😅

@matt-hb
matt-hb marked this pull request as ready for review September 28, 2026 22:28

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants