[STACKED on #1016] fix(guest): make gateway refresh failover atomic - #962
Merged
kvinwang merged 5 commits intoAug 6, 2026
Conversation
kvinwang
force-pushed
the
codex/fix-guest-local-provider-inventory
branch
2 times, most recently
from
August 5, 2026 09:22
ac918d6 to
cbb6665
Compare
Base automatically changed from
codex/fix-guest-local-provider-inventory
to
codex/fix-guest-kms-failover-order
August 5, 2026 10:24
kvinwang
force-pushed
the
codex/fix-guest-gateway-refresh-failover
branch
2 times, most recently
from
August 6, 2026 02:48
48f99b3 to
9716c70
Compare
kvinwang
changed the base branch from
codex/fix-guest-kms-failover-order
to
fix/guest-local-provider-inventory-master
August 6, 2026 02:48
kvinwang
force-pushed
the
fix/guest-local-provider-inventory-master
branch
from
August 6, 2026 02:52
3ca0e7e to
845af54
Compare
kvinwang
force-pushed
the
codex/fix-guest-gateway-refresh-failover
branch
from
August 6, 2026 02:52
9716c70 to
e4a3156
Compare
kvinwang
merged commit Aug 6, 2026
e1745d6
into
fix/guest-local-provider-inventory-master
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Gateway refresh failover updated endpoint/state pieces incrementally. If the first endpoint failed and the next succeeded, readers could observe a mixed old/new gateway state during the transition.
Root cause and fix
Build the successful refresh result off to the side and atomically replace gateway state only after one endpoint completes.
Implementation
The branch records the following focused implementation work:
fix(guest): make gateway refresh failover atomicstyle(guest): format gateway refresh testsfix(guest): retain gateway keys across failover attemptsstyle(guest): format gateway failover closureChanged paths:
dstack/dstack-util/src/system_setup.rsScope
This PR addresses one logical
guestfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-guest-local-provider-inventoryVerification
git diff --check origin/codex/fix-guest-local-provider-inventory..origin/codex/fix-guest-gateway-refresh-failover: passed.