ci: build every pull request, not only those based on main - #20
Merged
Conversation
rasros
force-pushed
the
ci/build-stacked-prs
branch
from
August 13, 2026 19:25
7b39d0a to
dd9f868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.ymlruns on every pull request rather than only those based onmain.Why
The workflow already ran on pull requests, so this is not about turning CI on; it is about which
pull requests it covers.
pull_request: branches: [ main ]means a stacked pull request — one branchbased on another, targeting that other branch — gets no checks at all and can merge unverified.
klause hit this and dropped the filter; the change here is the same, comment included, so the repos
agree.
pushstays restricted tomain, so this adds no duplicate runs beyond the stacked case itis meant to cover.
Testing
The workflow parses, and its trigger now matches klause's byte for byte:
pull_requestpresent withno base filter,
pushstill[ main ].