chore: update kbuild to 1.3.1 - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the kbuild conventions from 1.2.10 to 1.3.1.
1.3.0 added ABI validation, so
checkrunscheckKotlinAbiand fails until referencedumps exist. The generated dumps (646 lines) are in this commit for that reason — the bump
is not separable from them.
1.3.1 fixes detekt analysing commonMain and jvmMain as one compilation on multiplatform
projects, which broke expect/actual resolution, and aligns the ktlint rule set with the detekt
engine version.
Testing
updateKotlinAbithencheckKotlinAbi: passes against the committed dumps.detektMainJvmanddetektTestJvmreport SKIPPED, so the 1.3.1 fix is active here.detekt: nocompiler errors found during analysis.