fix: start self-learning worker from TUI - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
What changed
Root cause
The legacy Rich CLI called
_ensure_detached_learning_worker(), but the primary Bubble Tea JSONL backend did not. v2.0.3 was the latest release, so normal TUI launches could exit without any background worker.Validation
make checkmake lintmake test(212 tests)python3.12 -m unittest tests.test_tui_protocol tests.test_learning_worker tests.test_distribution -v./venv/bin/python scripts/wheel_smoke.pymake docs-checkmake shell-checkgit diff --checkNo credentials or user data are included.