fix: sync standards from v2, not main - #45
Merged
Conversation
The workflow held two defaults for the same value and they disagreed: the dispatch input defaulted to v2 while the `with:` fallback -- the one a scheduled run uses, because cron supplies no inputs -- said main. So manual syncs read v2 and the monthly sync read main, and this repository took whichever branch had spoken last. That is what flipped LICENSE between 2026 and 2025 every month. main has not moved in evergine-standards since 2026-03-19; v2 is twenty commits ahead and is what this workflow already pins for the reusable itself. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/sync-standards.ymlheld two defaults for the same value, and they disagreed:workflow_dispatch.inputs.ref.default"v2"with: ref: ${{ github.event.inputs.ref || 'main' }}'main'scheduleruns — cron supplies no inputsSo a manual sync read
evergine-standards@v2and the monthly cron read@main, and this repository ended up with whichever branch had spoken last. That is what flippedLICENSEbetweenCopyright (c) 2026andCopyright (c) 2025month after month — the copyright year was the visible symptom, not the bug.maininevergine-standardshas not moved since 2026-03-19;v2is twenty commits ahead and is the branch this workflow already pins for the reusable itself (_sync-standards-reusable.yml@v2). Readingv2is what the dispatch default already intended.Upstream companions: EvergineTeam/evergine-standards#4 fixes the same line in the template, EvergineTeam/evergine-standards#3 aligns
main's licence year so neither branch can reintroduce the flip. This edit is needed here separately becausesync-standards.ymlis not listed insync-manifest.json— the sync never rewrites a consumer's own workflow.🤖 Generated with Claude Code