Skip to content

Variable naming #19

Description

@NouraldinS

I just now at the end of my review noticed this thing

create table posts (
postId serial primary key,
userId integer references users(userId),
post text not null,
postType boolean not null
);

in your db.sql file, you've got a boolean property postType, which as far as I know, represents the privacy of a post. But why didn't you just name it public? In context, if it is true, then it is public, and otherwise it would be non-public (private)...

But since I'm already here, there's the first thing I noticed in your project, which is your start script, there's no meaning for having NODE_ENV=pro, because pro abbreviates (professional) not (production -intended-).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions