Conversation
king-shak
added
Pending Hardware Testing
JacobJBublitz
requested changes
Feb 4, 2020
king-shak
force-pushed
the
VisionSubsystem
branch
from
February 8, 2020 20:00
0a0b8d4 to
2995bc4
Compare
…ght of the Limelight in the calculations. Also, put in reminders because we need to get the actual height and mounting angle of the Limelight.
… inner target, modified VisionRotateToTargetCommand to get the proper angle to the target.
king-shak
force-pushed
the
VisionSubsystem
branch
from
February 8, 2020 22:59
35a02fb to
53c3a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds VisionSubsystem, which simply determines whether the Limelight has a target and calculates the distance to the target.
closes #58