feat(retentions): agregar métodos para borradores - #7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds draft-related Retentions APIs to the Java SDK and validates their HTTP behavior via resource tests, alongside a patch-version bump and changelog entry for the new surface area.
Changes:
- Add draft support methods to
RetentionsResource(updateDraft,copyToDraft,stampDraft) and a conveniencecancel(String id)overload. - Add unit tests asserting correct HTTP methods, paths, and request bodies for retention draft flows.
- Bump SDK version to
1.3.1and document the changes inCHANGELOG.md(and update README dependency snippets).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/io/facturapi/FacturapiResourcesTest.java | Adds coverage for retention draft create/update/copy/stamp/cancel/list request construction. |
| src/main/java/io/facturapi/resources/RetentionsResource.java | Introduces draft-oriented retention endpoints and a convenience cancel overload. |
| README.md | Updates dependency examples to version 1.3.1. |
| README.es.md | Updates dependency examples to version 1.3.1. |
| pom.xml | Bumps project version from 1.3.0 to 1.3.1. |
| CHANGELOG.md | Adds 1.3.1 entry describing the new retentions draft methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javorosas
approved these changes
Aug 3, 2026
javorosas
changed the title
javorosas
added a commit
that referenced
this pull request
Aug 24, 2026
* feat(retentions): agregar métodos para borradores (#7) * chore(retentions): add new retentions method for support drafts * chore: keep retention draft methods unreleased --------- Co-authored-by: javorosas <javier.rosasb@gmail.com> * feat(invoices): agregar métodos ZIP (#11) * Add invoice ZIP request methods * fix: align ZIP download method naming --------- Co-authored-by: javorosas <javier.rosasb@gmail.com> * fix!: return Java API error codes as strings * fix: only normalize numeric API error codes * fix: model property tax accounts as arrays * docs: update Java dependency snippets for 2.0.0 * docs: complete Java 2.0.0 changelog --------- Co-authored-by: Raúl García <141654545+raul-facturapi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios