Pin NuGet.Framework for .NET SDK 10.0.400; auto-remove on future major versions - #666
Draft
ITaluone wants to merge 2 commits into
Draft
Pin NuGet.Framework for .NET SDK 10.0.400; auto-remove on future major versions#666ITaluone wants to merge 2 commits into
NuGet.Framework for .NET SDK 10.0.400; auto-remove on future major versions#666ITaluone wants to merge 2 commits into
Conversation
- Do not Add pin to net framework build projects - Only add on build projects in general
dennisdoomen
marked this pull request as draft
August 30, 2026 11:21
Collaborator
|
I'm going to park this one until we have settled on a path in #638. Also, upgrades between 10.x must always be backwards compatible and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fallout-migratenow pinsNuGet.Framework7.9.0 on 10.x build projects, and removes that pin when the target Fallout major matches or moves beyond the marker.I chose the marker version v11 because of various comments mentioning this version upgrade in that major version.
If someone feels to leave it until v12, please ping me on that one.
Changes
RewriteCsprojsStepinserts this block into the firstItemGroupof only the_build.csproj:v11in the marker is the next major afterMigrationContext.FalloutVersion(the versionfallout-migrateresolved for this run).:startthrough:end.Why?
.NET SDK 10.0.400 loads
NuGet.Frameworks7.9.0.0 while evaluating the build project. Without an explicit pin, MSBuild fails when calling e.g.Solution.MyProject.GetTargetFrameworks(). The pin is only needed on the 10.x line. The marker tellsfallout-migrateto drop the block on v11 so consumers do not have to edit the csproj by hand.Proposed workaround migration for #638