Skip to content

fix: restore Docker builds after Next.js upgrade - #52

Merged
novoj merged 1 commit into
mainfrom
fix/docker-agent-bridge-build
Sep 18, 2026
Merged

novoj merged 1 commit into
mainfrom
fix/docker-agent-bridge-build

Conversation

@novoj

@novoj novoj commented Sep 18, 2026

Copy link
Copy Markdown

Description

Fixes the Docker build failure exposed after upgrading to Next.js 16.3.3. During next build, TypeScript checks src/tests/ai/agent-bridge.test.ts, which imports agent-bridge/lib.mjs; the Docker context previously excluded the entire agent-bridge directory.

Failed run: https://github.com/FgForrest/riffado/actions/runs/35384924483

src/tests/ai/agent-bridge.test.ts(15,8): error TS2307: Cannot find module '../../../agent-bridge/lib.mjs'

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Dependency update

Related Issues

None.

Changes Made

  • Keep agent-bridge/lib.mjs in the application Docker build context.
  • Continue excluding every other agent-bridge file.
  • Keep the sidecar and tests out of the final application image; the runner stage does not copy them.

Testing

  • docker build --progress=plain --target builder -t riffado-docker-debug:next-16.3.3-fixed .
  • pnpm format-and-lint:fix
  • pnpm type-check
  • pnpm test src/tests/ai/agent-bridge.test.ts (35 tests passed)
  • Verified the builder contains only agent-bridge/lib.mjs from the sidecar directory.

Test Environment

  • OS: Linux
  • Node version: 24.21.0
  • Docker client/server: 29.8.1 / 29.7.1

Checklist

  • My code follows the style guidelines of this project (pnpm format-and-lint)
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • Relevant existing unit tests pass locally with my changes
  • Type checking passes (pnpm type-check)
  • The Docker builder stage completes successfully

Database Changes

None.

Breaking Changes

None.

Additional Notes

The formatter/linter reports two pre-existing informational suggestions in src/tests/admin/elevated-cookie.test.ts. The Docker build also reports the existing PostHog build-argument secret warnings and instrumentation Edge Runtime warnings; this change introduces no new warnings.

Copilot AI lite review requested due to automatic review settings September 18, 2026 19:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@novoj
novoj merged commit cea234d into main Sep 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants