You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@BeyondMagic Hey! This PR was merged, but the entry landed on main still as a candidate, so Smoked isn't rendering on the site.
It looks like the merge happened without a formal "Approve" review being submitted, so publish-approved-theme-submission.yml never happened. the workflow's run history has no run for #383. The entry on main still shows:
"status": "candidate"
"catalogIndex": 100382 the 100000 + issue number placeholder, confirming the publish script never ran
Since the branch is deleted, the review-trigger path can't be replayed. Could you manually flip src/content/themes/smoked.json to "status": "published" and assign the next available catalogIndex (or re-run the publish script against it)?
Thanks, and if by chance I misunderstand the flow, and I'm jumping to conclusions, I apologize!
that was supposed to say "if i'm jumping to conclusions" lol, but thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate theme submission
Generated from #382.
Closes #382.
smokedcandidatedark,minimal,onelineReviewer checklist:
status: "candidate"until the theme is ready to appear publicly.