fix(proof): enforce effort relation boundaries - #253
Merged
Conversation
Reject create-time and later relation targets outside the source record's Effort. A record may still derive from its own governing Effort. Fail legacy cross-Effort relation reads with structured `PROOF_CROSS_EFFORT_RELATION` data instead of returning an empty page. Preserve missing-target error precedence. Stage reverse projections together so one valid create can both supersede and invalidate the same target without losing either back-link. Tests: - `pnpm verify` Fixes #251 Change-Id: Ifb21ca5f0f242090e6fcf3839a3edc7cc1c549fc
toeknee-figma
marked this pull request as ready for review
August 17, 2026 20:22
tonyketcham
self-requested a review
August 17, 2026 20:23
tonyketcham
approved these changes
Aug 17, 2026
tonyketcham
deleted the
stack/toeknee-figma/fix/proof-cross-effort-relations/enforce-effort-relation-boundaries--fb21ca5f
branch
August 17, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #251
What now works
derives_from,supersedes, andinvalidatesreject targets from another Effort.PROOF_CROSS_EFFORT_RELATION; missing targets still returnPROOF_DANGLING_RELATION.