Preserve low-rank Fourier subclasses in operations - #5374
Draft
FlorianPfaff wants to merge 2 commits into
Draft
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
LowRankHypertoroidalFourierDistributionused hard-coded base-class constructors in several instance operations. Consequently, subclasses silently collapsed back toLowRankHypertoroidalFourierDistributionafter:shift()centered_hermitianized()multiply()convolve()This is inconsistent with the subclass-preserving factory/operation contract used elsewhere in PyRecEst (including the dense Fourier and Fejer Fourier implementations).
Fix
Construct operation results through
type(self)and convert dense operands throughtype(self).from_dense(...). Numerical formulas, tensor-train operations, normalization, and public signatures are unchanged.Regression coverage
Adds a focused NumPy-only regression using a derived low-rank Fourier class. It verifies exact subclass preservation for shift, Hermitian repair, multiplication and convolution, including binary operations with a dense
HypertoroidalFourierDistributionoperand.Scope
mainatbaac3b1736bb8e81eafc1e3f69e10104636103b9