Reject non-real Bingham measurement and system vectors - #5376
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
BinghamFiltervalidates measurement and nonlinear system-output vectors by shape, complex dtype, finiteness, and unit norm after backend conversion. Boolean vectors therefore slip through because booleans are finite numeric values and, for example,[True, False]has norm one. The filter silently interprets that vector as[1, 0], turning an upstream type error into a valid-looking orientation measurement/state.Textual vectors can likewise reach backend-specific numerical conversion/arithmetic instead of being rejected consistently at the API boundary.
Fix
Validate raw vector inputs as unambiguously real numeric before converting them with the active backend. This rejects booleans, text/bytes, and complex values while preserving ordinary real Python lists and backend arrays.
Regression coverage
tests/filters/test_bingham_filter_real_vector_validation.pyverifies rejection of:The branch is based directly on current
mainatbaac3b1736bb8e81eafc1e3f69e10104636103b9and is 2 commits ahead / 0 behind. It supersedes the earlier closed, unmerged draft #5340 with a clean branch on the current head.