Fix JAX multivariate-normal PSD validation - #5380
Merged
Merged
Conversation
Contributor
✅MegaLinter analysis: Success
Notices
See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 21, 2026 06:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fix the JAX random backend's eager covariance validation for
multivariate_normal.The existing JAX CI regression
tests/backend/test_jax_random_multivariate_normal_validation.py::test_multivariate_normal_rejects_invalid_covariance_geometry[bad_cov3-cov must be positive semidefinite]fails on the current main-based JAX matrix because the indefinite covariance
diag(1, -0.1)is not rejected.Root cause / fix
_validate_multivariate_normal_covused JAXallcloseandeigvalshfor checks that are immediately converted to Python booleans. This is an eager validation path rather than a traced numerical kernel, and relying on JAX linear algebra here makes validation sensitive to backend/runtime behavior.Convert the already validated finite covariance to a host NumPy array and perform the symmetry and eigenvalue checks with NumPy. Sampling and returned arrays remain JAX-backed.
The existing
1e-8PSD tolerance and validation messages are unchanged.Evidence
The failure is present in the existing Python 3.12 and 3.13 JAX CI artifacts from current-main-based PR #5379. The repository already contains the exact regression test, so no duplicate test was added.
Scope
mainatb7d3edc9ac05600de5345dc20fd6f3db33154d86;