Follow the repository rename to forge-kernels - #22
Merged
Conversation
The repository is now Forge-researchlab/forge-kernels, matching the distribution name, so the repo URL, `pip install`, and the import all line up. GitHub 301-redirects the old URL, so nothing breaks meanwhile. Updated the references that are live: the Homepage and Issues URLs in pyproject.toml, the README title and its install command and issue links, and the two URLs in the issue-template config. Left the hackathon-era documents alone. docs/swiglu.md, docs/geglu.md, docs/hackathon_day1_audit.md and the LoRA analysis notes describe the tree as it stood on a given date, including paths like /workspace/kernel-POCs. Rewriting paths inside a dated record would make it a less honest record. Two comments in live code did need fixing, and one of them was wrong independently of the rename. forge/__init__.py described its sys.path insert as a hackathon shim needed because the kernels were unpackaged and pointed at /workspace/kernel-POCs. The kernels ship in the distribution now, so the insert is only useful in a bare checkout: in an installed copy it resolved to the parent of site-packages, which has no business on sys.path. It is now guarded on `kernels` not already being importable. Verified all three import paths afterwards: - checkout with PYTHONPATH=forge:. as documented - checkout with PYTHONPATH=forge only, where the shim supplies kernels - installed wheel, where the shim adds nothing and both packages resolve from site-packages, with patch/forward/backward/unpatch all working tests/ 276 passed, test_shape_guard 7/7, verify_lora_qwen_patch passes. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository is now
Forge-researchlab/forge-kernels, matching the distribution name, so the repo URL,pip install, and the import all line up. GitHub 301-redirects the old URL, so nothing breaks in the meantime.Updated
Live references only: the
HomepageandIssuesURLs inpyproject.toml, the README title plus its install command and issue links, and the two URLs in.github/ISSUE_TEMPLATE/config.yml.Deliberately not updated
docs/swiglu.md,docs/geglu.md,docs/hackathon_day1_audit.md,docs/phase3_fsdp2_design.mdand the LoRA analysis notes still saykernel-POCsand/workspace/kernel-POCs. They describe the tree as it stood on a specific date; rewriting paths inside a dated record would make it a less honest record, not a more accurate one.One comment that was wrong regardless of the rename
forge/forge/__init__.pydescribed itssys.pathinsert as a hackathon shim, needed because the kernels were unpackaged, and pointed at/workspace/kernel-POCs/kernels/. Since #20 the kernels ship in the distribution, so the insert is only useful in a bare checkout — and in an installed copy it resolved to the parent ofsite-packages, which has no business onsys.path. It is now guarded onkernelsnot already being importable, and the comment says what it actually does.Verification
All three import paths, after the change:
PYTHONPATH=forge:.(as documented)forge.patchcallable,kernelsfrom the repoPYTHONPATH=forgeonlykernelsfrom the repo/tmpsite-packagesOn the installed copy:
patched {'fused_linear_ce': 1, 'embedding': 1, 'swiglu': 2, 'rmsnorm': 5}, cosine vs eager 0.999952, training-step backward completes,unpatchrestores bitwise.Suites:
tests/276 passed / 4 skipped / 1 xfailed,test_shape_guard7/7,verify_lora_qwen_patchpasses withunpatchrestoring. Ruff clean, all 63 packages declared.