Skip to content

chore: migrate davinci flows and clients to new tenant - #757

Open
ancheetah wants to merge 1 commit into
mainfrom
migrate-davinci-flows
Open

chore: migrate davinci flows and clients to new tenant#757
ancheetah wants to merge 1 commit into
mainfrom
migrate-davinci-flows

Conversation

@ancheetah

@ancheetah ancheetah commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

JIRA Ticket

None

Description

  • Migrates any remaining SDK e2e flows to the new tenant (SDK Web environment, env ID: 356a254c-cba3-4ade-be1a-860136e8df01).
  • Simplifies QR Code flow into a new flow.
  • Several tests used similar variants of Web MFA Device Registration/Authentication flow. All of those flows have been consolidated into one Web MFA Device Registration/Authentication flow in the new tenant and tests updated.
  • Re-organizes flows into less OAuth clients, namely the following categories: AutoCollectors, MFA, Form Fields, Login/Registration, OIDC Client.
  • Adds a country code input to phone number collector with hardcoded options.
  • Updated DaVinci E2E Flows List. Please review here: https://docs.google.com/spreadsheets/d/1VdL7EONaj37aiyq6TKNm5Jcusf7tuBp3dSe-cO1t94Y/edit?usp=sharing
  • I would also encourage you to review the flows in the new tenant and provide feedback about them or their organization into respective applications/clients

NOTE: Sample app flows have not yet been migrated to new tenant

Screenshot 2026-08-17 at 5 55 46 PM

@changeset-bot

changeset-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 07fa329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e6cc598-8c86-4214-a3a4-13c63dec19c7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 07fa329

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded 2s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded 2m 14s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-08-17 22:12:22 UTC

@pkg-pr-new

pkg-pr-new Bot commented Aug 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@757

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@757

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@757

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@757

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@757

@forgerock/recognize

pnpm add https://pkg.pr.new/@forgerock/recognize@757

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@757

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@757

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@757

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@757

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@757

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@757

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@757

commit: 07fa329

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Deployed 39fbb54 to https://ForgeRock.github.io/ping-javascript-sdk/pr-757/39fbb548897d6bd82d0bc9361549dca0af017ce0 branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🆕 New Packages

🆕 @forgerock/journey-client - 92.6 KB (new)
🆕 @forgerock/journey-client - 0.0 KB (new)
🆕 @forgerock/device-client - 10.0 KB (new)
🆕 @forgerock/device-client - 0.0 KB (new)

➖ No Changes

➖ @forgerock/sdk-utilities - 18.6 KB
➖ @forgerock/recognize - 4284.4 KB
➖ @forgerock/sdk-request-middleware - 4.6 KB
➖ @forgerock/iframe-manager - 3.2 KB
➖ @forgerock/sdk-oidc - 5.7 KB
➖ @forgerock/storage - 1.5 KB
➖ @forgerock/sdk-logger - 1.6 KB
➖ @forgerock/oidc-client - 35.4 KB
➖ @forgerock/sdk-types - 9.1 KB
➖ @forgerock/davinci-client - 59.1 KB
➖ @forgerock/protect - 144.6 KB

15 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

cerebrl
cerebrl reviewed Aug 18, 2026
View reviewed changes
Comment thread e2e/davinci-suites/src/basic.test.ts
return request
.url()
.includes('https://auth.pingone.ca/02fb4743-189a-4bc7-9d6c-a919edfe6447/as/authorize');
.includes('https://auth.pingone.ca/356a254c-cba3-4ade-be1a-860136e8df01/as/authorize');

@cerebrl cerebrl Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: All of these IDs make me just a bit nervous. I feel we should centralize all of these IDs and then pass them around, rather than needing to hardcode them all throughout our files.

vatsalparikh
vatsalparikh reviewed Aug 18, 2026
View reviewed changes

@vatsalparikh vatsalparikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about using old env for protect

Comment thread e2e/davinci-app/main.ts
throw new Error(`Failed to initialize oidc client: ${oidcResult.error}`);
}
const oidcClient = oidcResult;
const protectApi = protect({ envId: '02fb4743-189a-4bc7-9d6c-a919edfe6447' });

@vatsalparikh vatsalparikh Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason protect is still using the old env ending in 447?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vatsalparikh vatsalparikh vatsalparikh left review comments
@cerebrl cerebrl cerebrl approved these changes
@ryanbas21 ryanbas21 ryanbas21 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ancheetah @cerebrl @vatsalparikh @ryanbas21