Moveable ghost hack - #62
Open
FramePerfection wants to merge 5 commits into
Open
Conversation
FramePerfection
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #4, and obsolete #59 by generalizing its idea of moving the ghost hack "out of the way" to prevent RAM allocation collisions.
The reason why #59 is not preferrable is thus far undocumented, but very intentional:
Most binary ROM hacks allocate RAM banks in regions beyond 0x80500000, so it is more than likely to encounter level data there - exactly the same problem we are facing with the Usamune crash, just in different memory regions.
This impossible to resolve conflict motivates handing control over the offset to the user, at least to a degree.