Fix Abnahme-Feedback: Timestamps, Offer-Image, Registrierung u. a. - #48
Merged
Conversation
Set DRF DATETIME_FORMAT and switch TIME_ZONE to UTC so created_at and updated_at match the documented ...Z format across all endpoints.
Fixes #42 Reject a duplicate username with 400 instead of a 500 IntegrityError and restrict type to the customer/business choices.
Reject non-status fields on order update and return no orders for users without a customer or business profile.
Fixes #43 Support ordering by updated_at/rating and check the customer profile via an existence query so a profile-less user gets 403 instead of 500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
Behebt das Abnahme-Feedback und die im Code-Review gefundenen Abweichungen zur Endpoint-Doku. Alle Punkte sind als Issues dokumentiert und hier als je eigener Commit umgesetzt.
Enthaltene Fixes
DATETIME_FORMAT+TIME_ZONE=UTC→ allecreated_at/updated_atals...ZtypealsChoiceFielduploaded_atemail/created_attype/user/usernameim Profil-PATCH read-onlyimagelöscht das Bild nicht mehr (nur explizitesnullleert)id, title, image, description, detailsbeschränktIsCustomerUserüber Existenz-Query (profilloser User → 403 statt 500)Zusätzliche Härtungen (ohne Issue): Ablehnung nicht erlaubter Felder beim Order-Update, Queryset-Scoping für profillose User,
ordering-Validierung bei Offers, Ordering nachupdated_at/ratingbei Reviews.Tests
Verbleibend (separat, nicht in diesem PR)
Robustheits-/Konformitäts-Restpunkte sind weiterhin als offene Issues erfasst, falls gewünscht.