Move app tests into dedicated tests packages - #50
Merged
Conversation
Relocate each app's test modules out of the api package into a dedicated tests/ package and drop the empty default tests.py stubs, mirroring the existing core/tests layout. Keeps the api package focused on API code only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mentor feedback: test modules should live in a dedicated
tests/package per app, not inside theapi/package (theapi/package should contain only API code). Thecoreapp already follows this layout withcore/tests/.Changes
<app>/api/test_*.pyinto a new<app>/tests/package (with__init__.py):auth_app,offers_app,orders_app,profiles_app,reviews_apptests.pystubs (# Create your tests here.) from all five apps.No test logic changed — files were moved verbatim (all imports are absolute, so no edits needed). pytest discovery (
testpaths = ["."],test_*.py) and coverageomit(*/tests/*) already cover the new location.Tests
179 passed, coverage 98.26%, ruff clean.