Move base-info endpoint into its own app - #53
Merged
Conversation
Relocate the base-info API out of the core project package into a dedicated base_info_app, so core only holds project configuration. The URL name stays 'base-info', so no callers change. Register the new app, point the api include at it, move its tests, and extend the architecture test's expected app list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mentor feedback (blocking): the
base-infoAPI view lives inside thecoreproject package (core/api/), where it does not belong.coreshould only hold Django project configuration; the endpoint is a domain concern and belongs in its own app, consistent with the other*_apppackages.Changes
base_info_appwithapps.py,api/views.py(BaseInfoView), andapi/urls.py.base_info_app/tests/.core/api/entirely.base_info_appinINSTALLED_APPSand point theapi/include atbase_info_app.api.urls.test_app_architecture.py'sEXPECTED_PROJECT_APPSwith the new app.The URL name (
base-info) and path (/api/base-info/) are unchanged, so no callers or contract tests change.Verification
manage.py check: no issues