perf(build): narrow SDK dependencies and external-source test targets - #2216
Merged
limityan merged 1 commit intoAug 11, 2026
Merged
Conversation
limityan
marked this pull request as ready for review
August 11, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product-fulldependency with the explicit Core capability closure used by its current local protocol and construction pathBuild and dependency impact
Normal/build package-version closure for
bitfun-sdk-host-app:x86_64-pc-windows-msvcaarch64-apple-darwinx86_64-unknown-linux-gnuThe current SDK protocol does not expose Remote Connect, SSH workspace execution, or Function Agent capabilities. Those owners now leave the SDK Host graph instead of being inherited through
product-full. Debug Agent behavior still retains its reviewed LSP owner.Cargo.lockis byte-identical to the base and remains at 1176 packages. This PR adds no crate, third-party package, root dependency, broad feature umbrella, workflow, CI job, or CI command. The dependency graph reduction is not presented as a measured wall-clock improvement.Test topology
All 19 moved test leaves are byte-for-byte moves. Runtime-free tests with identical owner, dependency, platform, and failure semantics share wrapper targets. OpenCode MCP child-process tests, managed plugin/service tests, and Node script-runtime tests remain separate. Focused execution remains available through
--test <target> <module>::.The boundary checker now locks the exact reviewed leaves and rejects Cargo
required-featuresonly on the four grouped targets. It handles bare, quoted, and Unicode-escaped TOML keys while leaving independent targets free to adopt legitimate feature gates.Behavior and architecture
None; unsupported remote execution does not fall back to local execution.Validation
cargo test --offline --locked -p bitfun-sdk-host -p bitfun-sdk-host-app -p bitfun-product-capabilities -p bitfun-opencode-adapter -p bitfun-claude-code-adapter -p bitfun-codex-adapter -p bitfun-external-sourcesnode --test scripts/check-core-boundaries.test.mjs— 79/79node scripts/check-core-boundaries.mjscargo tree -e normal,buildclosure comparisongit diff --checkThree independent adversarial review passes covered architecture/feature ownership, test semantics/failure isolation, and scope/performance evidence. Review findings around removable test leaves, hidden
required-features, Unicode-escaped TOML keys, and target-level scoping were fixed and re-reviewed before publishing.