test(blackbox): probe the wiki over the scheme it actually serves - #197
Merged
Conversation
blackbox.test.yaml built every fixture around instance="https://lemmiwinks.matrix.elysium" and instance="https://10.0.99.30". The real targets are plain HTTP, and targets/blackbox.yaml says so at some length: only port 3000 listens inside the wiki container, nothing is on 3443, TLS is off, and the host maps 443 anyway — so an https probe is refused instantly. That file records this as something already learned the hard way, because the first deploy of it reported the wiki down while it was serving fine. This is not only a label. EndpointUnreachable's summary is templated from {{ $labels.instance }}, so lines 45 and 63 were asserting the alert text an on-call reads at 3am — pinning it to a URL that refuses instantly, and pinning it to exactly the mistake the targets file exists to warn about. Confirmed the fixtures genuinely assert the scheme rather than passing regardless: leaving the summary at https while the instance says http fails the run. `make validate` passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blackbox alert fixtures built every case around
instance="https://lemmiwinks.matrix.elysium"andinstance="https://10.0.99.30".The real targets are plain HTTP, and
targets/blackbox.yaml:8-12says so at some length:So the fixtures asserted the one scheme that file exists to warn against.
It wasn't only a label
I expected this to be cosmetic —
instanceis just a label and the tests passed. It isn't.EndpointUnreachable's summary is templated from{{ $labels.instance }}(blackbox.rules.yaml:44), so lines 45 and 63 were pinning the alert text an on-call reads to a URL that refuses instantly.Verified the fixtures genuinely assert the scheme rather than passing regardless — a negative control leaving the summary at
httpswhile the instance sayshttpfails the run:Verification
promtool test rules stacks/observability/prometheus/tests/blackbox.test.yaml→ SUCCESSmake validate→ all checks passPurely a fixture change — no rule, target, or probe config is touched.
Context: found while fixing #74 (stale TLS documentation claims), deliberately left out of #196 to keep that PR scoped to TLS wording.
🤖 Generated with Claude Code