fix: keep the daemon reachable on a refused change, classify local save errors, and make every string translatable

AGENTS.md

@@ -81,11 +81,12 @@ Run `just ci` before claiming anything done.
   already there, including a symlink — so nothing planted in the download
   directory is ever followed or overwritten.
 - **Every translatable string is a literal.** `tests/i18n.test.js`
-  (`tests/support/i18n.js`'s `nonLiteralGettextCalls`) fails if any `_()`
-  call's message, or either of `_n()`'s two arguments, is a variable,
-  property access or template rather than a string literal — invisible to
-  `xgettext -k_ -k_n:1,2` exactly the same way a translator would never
-  see it.
+  (`tests/support/i18n.js`'s `nonLiteralGettextCalls`) reads the source of
+  every file under `modules/`, `prefs.js` and `extension.js`, and fails if
+  any `_()` call's message, or either of `_n()`'s two arguments, is a
+  variable, property access or template rather than a string literal —
+  invisible to `xgettext -k_ -k_n:1,2` exactly the same way a translator
+  would never see it.
 - **No JavaScript on the docs pages.** `docs/index.html` ships no
   `<script>`; `just test-docs` fails the build if one appears.
 - **The shared template files are byte-locked.** Everything in
@@ -98,11 +99,12 @@ Run `just ci` before claiming anything done.
 
 Write the failing test first (RED → GREEN). Layers:
 
-- **Vitest** (`just test`) — every module under `modules/`, `extension.js`
-  and `prefs.js` run exactly as shipped. `prefs.js` (Adw/Gtk widget
+- **Vitest** (`just test`) — every module under `modules/` except
+  `io.js`, and `extension.js`, run exactly as shipped; `prefs.js` is
+  excluded and imported by no test. `prefs.js` (Adw/Gtk widget
   construction) and `modules/io.js` (Soup/Gio plumbing, checked instead
-  against the real daemon) are excluded from coverage — identically in
-  `vitest.config.js` and `sonar-project.properties`. Stubs for `gi://` and
+  against the real daemon) are excluded from coverage — identically in `vitest.config.js`
+  and `sonar-project.properties`. Stubs for `gi://` and
   `resource:///` imports live in `tests/stubs/`; a fake daemon and a small
   fake Shell world are in `tests/support/`.
 - **`just localapi-check`** (`scripts/localapi-check.js`, under plain
@@ -181,22 +183,22 @@ and `tests/support/world.js` (`tests/support/actors.js` is template-locked).
 ## Settings keys
 
 `modules/settings.js` is the single source of truth: `KEYS` (the schema
-key names), `SHORTCUT_KEYS` (the one accelerator key), and `SETTINGS` (each
-key's gschema type plus the untranslated label and detail text `prefs.js`
-builds every row from). It imports nothing, so `tests/settings.test.js`
-checks it on plain Node against the gschema.
+key names), `SHORTCUT_KEYS` (the one accelerator key), `SETTINGS` (each
+key's gschema type), and `settingText` (the label and detail `prefs.js`
+builds every row from, each a literal `_()` call). It imports nothing, so
+`tests/settings.test.js` checks it on plain Node against the gschema.
 
 Adding, renaming or removing a setting means updating all three together,
 in this order, or the cross-check test fails:
 
 1. `schemas/org.gnome.shell.extensions.quickts.gschema.xml` — the type,
    default, summary and description (and `<range>` for `max-menu-height`,
    currently 0–2000).
-2. `modules/settings.js` — the key constant, its `SETTINGS` entry, and any
-   place in `modules/panel.js` or `prefs.js` that reads it through `KEYS`
-   or `SHORTCUT_KEYS`.
+2. `modules/settings.js` — the key constant, its `SETTINGS` entry, its
+   `settingText` case, and any place in `modules/panel.js` or `prefs.js`
+   that reads it through `KEYS` or `SHORTCUT_KEYS`.
 3. `prefs.js` — only if the widget it needs is not already covered by
-   `describe()`'s label/detail lookup (`Adw.SpinRow` needs its own
+   `settingText`'s label/detail lookup (`Adw.SpinRow` needs its own
    `Gtk.Adjustment` bounds, kept equal to the gschema's `<range>`).
 
 `AdvertiseRoutes` (the advertised-subnets row in preferences) is

README.md

@@ -20,8 +20,9 @@ testing, packaging and releasing.
 sudo tailscale set --operator=$USER
 ```
 
-Without that, the daemon refuses the socket and QuickTS says so in the menu
-rather than showing a tailnet that is silently disconnected.
+Without it the daemon refuses every change with a `403`. QuickTS says so in
+the menu and offers the command, rather than leaving a switch that silently
+flips back.
 
 ## Install
 

docs/index.html

@@ -1179,9 +1179,13 @@ <h2 id="keyboard-title">Keyboard</h2>
                         </tbody>
                     </table>
                     <p>
-                        A bare key, or one with only <kbd class="kbd">Shift</kbd>, is
-                        not accepted: it would be taken from every application. The
-                        shortcut does nothing on the lock screen or the login screen.
+                        A bare key is not accepted: it would be taken from every
+                        application. <kbd class="kbd">Shift</kbd> alone is accepted only
+                        with a key that types nothing, such as
+                        <kbd class="kbd">Shift</kbd>+<kbd class="kbd">F5</kbd>;
+                        <kbd class="kbd">Shift</kbd>+<kbd class="kbd">A</kbd> is how a
+                        capital A is typed. The shortcut does nothing on the lock screen
+                        or the login screen.
                     </p>
                     <p>
                         It is stored under <code>quickts-open-menu</code>. The prefix
@@ -1420,7 +1424,7 @@ <h3>Every module</h3>
                                     <code>menu-items.js</code>,
                                     <code>navigable-section.js</code>,
                                     <code>ping.js</code>, <code>settings.js</code>,
-                                    <code>taildrop.js</code>
+                                    <code>taildrop.js</code>, <code>text.js</code>
                                 </td>
                             </tr>
                             <tr>
@@ -1429,7 +1433,9 @@ <h3>Every module</h3>
                                     Why a request to tailscaled failed, as a
                                     <code>REASON</code> value rather than a string.
                                 </td>
-                                <td data-label="Imports" class="muted">—</td>
+                                <td data-label="Imports" class="muted">
+                                    <code>text.js</code>
+                                </td>
                             </tr>
                             <tr>
                                 <td data-label="Module">
@@ -1443,7 +1449,7 @@ <h3>Every module</h3>
                                 <td data-label="Imports" class="muted">
                                     <code>menu-items.js</code>, <code>mullvad.js</code>,
                                     <code>navigable-section.js</code>,
-                                    <code>settings.js</code>
+                                    <code>settings.js</code>, <code>text.js</code>
                                 </td>
                             </tr>
                             <tr>
@@ -1499,7 +1505,8 @@ <h3>Every module</h3>
                                     menu shares.
                                 </td>
                                 <td data-label="Imports" class="muted">
-                                    <code>errors.js</code>, <code>warnings.js</code>
+                                    <code>errors.js</code>, <code>text.js</code>,
+                                    <code>warnings.js</code>
                                 </td>
                             </tr>
                             <tr>
@@ -1552,7 +1559,8 @@ <h3>Every module</h3>
                                     <code>health.js</code>, <code>layout.js</code>,
                                     <code>menu-items.js</code>, <code>routes.js</code>,
                                     <code>settings.js</code>,
-                                    <code>taildrop-section.js</code>
+                                    <code>taildrop-section.js</code>,
+                                    <code>text.js</code>
                                 </td>
                             </tr>
                             <tr>
@@ -1626,7 +1634,7 @@ <h3>Every module</h3>
                                 </td>
                                 <td data-label="Imports" class="muted">
                                     <code>inbox.js</code>, <code>menu-items.js</code>,
-                                    <code>taildrop.js</code>
+                                    <code>taildrop.js</code>, <code>text.js</code>
                                 </td>
                             </tr>
                             <tr>
@@ -1638,6 +1646,15 @@ <h3>Every module</h3>
                                     <code>collate.js</code>
                                 </td>
                             </tr>
+                            <tr>
+                                <td data-label="Module"><code>text.js</code></td>
+                                <td data-label="Job">
+                                    Fills a translated sentence's <code>%s</code> and
+                                    <code>%d</code> in order, without reading
+                                    <code>$</code> patterns in the values.
+                                </td>
+                                <td data-label="Imports" class="muted">—</td>
+                            </tr>
                             <tr>
                                 <td data-label="Module"><code>timing.js</code></td>
                                 <td data-label="Job">

modules/device-section.js

@@ -17,6 +17,7 @@ import {
     problemMessage,
 } from './menu-items.js';
 import { NavigableSection } from './navigable-section.js';
+import { fill } from './text.js';
 
 /** The device submenu. */
 export class DeviceSection {
@@ -52,8 +53,7 @@ export class DeviceSection {
                 this._visibleNodes(state).find(node => node.id === id) ?? null,
             detailTitle: node => node.name,
             renderList: (menu, state, open) => this._renderDevices(menu, state, open),
-            renderDetail: (menu, node, state) =>
-                this._renderDeviceActions(menu, node, state),
+            renderDetail: (menu, node) => this._renderDeviceActions(menu, node),
         });
     }
 
@@ -113,16 +113,11 @@ export class DeviceSection {
      *
      * @param {object} menu The submenu to fill.
      * @param {object} node A normalized node.
-     * @param {object} state A snapshot.
      */
-    _renderDeviceActions(menu, node, state) {
+    _renderDeviceActions(menu, node) {
         const { _ } = this._i18n;
 
         const address = node.ips.at(0) ?? '';
-        const fqdn =
-            node.name && state.magicDNSSuffix
-                ? `${node.name}.${state.magicDNSSuffix}`
-                : node.name;
 
         if (address === '') {
             addDisabledRow(menu, _('No address'));
@@ -147,12 +142,12 @@ export class DeviceSection {
             this,
         );
 
-        if (fqdn && fqdn !== node.name) {
+        if (node.dnsName) {
             addRow(
                 menu,
                 _('Copy DNS name'),
                 'edit-copy-symbolic',
-                () => copyText(fqdn, this._gicon, this._i18n),
+                () => copyText(node.dnsName, this._gicon, this._i18n),
                 this,
             );
         }
@@ -228,12 +223,10 @@ export class DeviceSection {
 function formatPing(result, { _ }) {
     const latency = String(result.latencyMs);
 
-    if (result.route === ROUTE.DIRECT) return _('%s ms, direct').replace('%s', latency);
+    if (result.route === ROUTE.DIRECT) return fill(_('%s ms, direct'), latency);
     if (result.route === ROUTE.RELAY && result.relay)
-        return _('%s ms, relayed via %s')
-            .replace('%s', latency)
-            .replace('%s', result.relay);
-    if (result.route === ROUTE.RELAY) return _('%s ms, relayed').replace('%s', latency);
+        return fill(_('%s ms, relayed via %s'), latency, result.relay);
+    if (result.route === ROUTE.RELAY) return fill(_('%s ms, relayed'), latency);
 
-    return _('%s ms').replace('%s', latency);
+    return fill(_('%s ms'), latency);
 }