[iOS] Reduce RevenueCat SDK size - #23
Merged
Merged
Conversation
…wise init Swift 6.4 (Xcode 27) synthesizes a memberwise `init(stringRepresentation:)` for `PaywallColor` (the optional `_underlyingColor` gets an implicit nil default and is dropped from the parameter list), which collides with the public throwing `init(stringRepresentation:)`, failing with 'invalid redeclaration of synthesized memberwise init' / 'ambiguous use of init'. Declaring the designated initializer in the type body suppresses the synthesized memberwise init. Gated behind '#if compiler(>=6.4)' so older toolchains keep the original extension-based arrangement and are unchanged.
nesterenkodm
left a comment
nesterenkodm
left a comment
There was a problem hiding this comment.
cool, this is a good optimization
epenm
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MNA-5346
Goodnotes only consumes the core
RevenueCatproduct, while the fork still contained several unused products, runtime features, tests, examples, and upstream development tooling.Description
RevenueCatproduct and target with no external package dependencies.RevenueCat.swiftmodulesize by 40.5%.Tested with:
swift build -c release --target RevenueCatGNISI-Packagetest suite: 86 tests passed