Retract between non-adjacent in-stock cuts - #516
Open
jeffc wants to merge 1 commit into
Open
Conversation
between non-adjacent contours in a pocket, even not crossing a boundary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a clause to gcode generation which forces a retract when fast-moving between non-adjacent contours in a pocket, even if that move doesn't cross a boundary
Before:
After:
This fix replaces the G0 fast move through stock between the outer perimeter cuts and the next set of contours (in this case, the rightmost section of the pocket). I broke a few bits on this move before I realized what was happening 🙃
Note that this might cause a slight merge conflict with #513 ; if you approve and merge either that one or this one first, I'll update the remaining one to address the conflict.