Skip to content

Review git patches and expand integration coverage - #12

Open
HartBrook wants to merge 1 commit into
mainfrom
test/diff-first-integration-review
Open

HartBrook wants to merge 1 commit into
mainfrom
test/diff-first-integration-review

Conversation

@HartBrook

Copy link
Copy Markdown
Owner

The reviewer previously selected changed filenames and then read whole files, which could include unrelated legacy or unstaged code while missing regressions visible only in deleted lines, renames, or workflow patches. Git-based scopes now review the patch first, with an initial-commit fallback and an explicit zero-pass response for an empty staged diff. Aggregate JSON also has a documented, consistent issues schema.

The integration suite now covers those review scopes alongside auto-fix behavior and tidy cleanup. It checks the final behavior of both repaired fixture bugs, recognizes equivalent finding descriptions without requiring a line number, and stops immediately with the underlying Claude CLI error when a live call fails. The contributor guide and offline validation checks reflect the expanded coverage.

Validation:

  • make test — 69 passed.
  • Full integration harness replay with a mock Claude CLI — 23 passed.
  • Live make integration was reported passing before the final harness cleanup; the final revision could not be rerun here because this environment has no Claude login or API key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant